From 5676d9874df5bf66db5e60b6a3d2e2b3b288ec07 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Mon, 25 Aug 2014 10:42:59 -0600 Subject: [PATCH] Don't leak temp fd in sudo_edit_copy_tfiles(). Fix fd leak in error path in sudo_edit_copy_tfiles(). --- src/sudo_edit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sudo_edit.c b/src/sudo_edit.c index c289edac0..c1e85ece4 100644 --- a/src/sudo_edit.c +++ b/src/sudo_edit.c @@ -228,6 +228,8 @@ sudo_edit_create_tfiles(struct command_details *command_details, sudo_warn("%s", tf[j].tfile); else sudo_warnx(U_("%s: short write"), tf[j].tfile); + close(ofd); + close(tfd); debug_return_int(-1); } } @@ -342,6 +344,7 @@ sudo_edit_copy_tfiles(struct command_details *command_details, sudo_warnx(U_("contents of edit session left in %s"), tf[i].tfile); } close(ofd); + close(tfd); } debug_return_int(errors); } -- 2.40.0