From 5601a13c91e2be79f30cd4f600f4ab24c0a82827 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sat, 5 Nov 2022 12:03:27 -0700 Subject: [PATCH] CMake: fix variables used for FreeType CMake with `--warn-uninitialized -Werror=dev` identified there was a problem here: CMake Error (dev) at plugin/lasi/CMakeLists.txt:25 (target_include_directories): uninitialized variable 'Freetype_INCLUDE_DIRS' CMake Error (dev) at plugin/lasi/CMakeLists.txt:31 (target_link_libraries): uninitialized variable 'Freetype_LIBRARIES' Gitlab: fixes #2291 --- CHANGELOG.md | 3 ++- cmd/smyrna/CMakeLists.txt | 4 ++-- lib/glcomp/CMakeLists.txt | 4 ++-- plugin/lasi/CMakeLists.txt | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e72805990..38040bdf1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,7 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - The CMake build system no longer uses the final install location as the staging area for example graphs and templates during `cpack`. This bug was introduced in Graphviz 4.0.0. #2232 -- The CMake build system uses a corrected path to DevIL headers when discovered. +- The CMake build system uses corrected paths to DevIL and FreeType headers and + libraries when discovered. ## [7.0.0] – 2022-10-22 diff --git a/cmd/smyrna/CMakeLists.txt b/cmd/smyrna/CMakeLists.txt index babe6eb14..e2df60059 100644 --- a/cmd/smyrna/CMakeLists.txt +++ b/cmd/smyrna/CMakeLists.txt @@ -87,7 +87,7 @@ if(with_smyrna) target_include_directories(smyrna SYSTEM PRIVATE ${EXPAT_INCLUDE_DIRS} ${FONTCONFIG_INCLUDE_DIRS} - ${Freetype_INCLUDE_DIRS} + ${FREETYPE_INCLUDE_DIRS} ${GLUT_INCLUDE_DIRS} ${GTK2_INCLUDE_DIRS} ${GTKGLEXT_INCLUDE_DIRS} @@ -109,7 +109,7 @@ if(with_smyrna) xdot ${EXPAT_LIBRARIES} ${FONTCONFIG_LIBRARIES} - ${Freetype_LIBRARIES} + ${FREETYPE_LIBRARIES} ${GLUT_LIBRARIES} ${GTK2_LIBRARIES} ${GTKGLEXT_LIBRARIES} diff --git a/lib/glcomp/CMakeLists.txt b/lib/glcomp/CMakeLists.txt index 536fd05ca..fd9c7c872 100644 --- a/lib/glcomp/CMakeLists.txt +++ b/lib/glcomp/CMakeLists.txt @@ -41,7 +41,7 @@ if(with_smyrna) ) target_include_directories(glcomp SYSTEM PRIVATE - ${Freetype_INCLUDE_DIRS} + ${FREETYPE_INCLUDE_DIRS} ${GLUT_INCLUDE_DIRS} ${GTK2_INCLUDE_DIRS} ${PANGOCAIRO_INCLUDE_DIRS} @@ -53,7 +53,7 @@ if(with_smyrna) endif() target_link_libraries(glcomp PRIVATE - ${Freetype_LIBRARIES} + ${FREETYPE_LIBRARIES} ${GLUT_LIBRARIES} ${GTK2_LIBRARIES} ${PANGOCAIRO_LIBRARIES} diff --git a/plugin/lasi/CMakeLists.txt b/plugin/lasi/CMakeLists.txt index f7f20d6aa..e3f7abd9a 100644 --- a/plugin/lasi/CMakeLists.txt +++ b/plugin/lasi/CMakeLists.txt @@ -23,13 +23,13 @@ if(Freetype_FOUND AND LASI_FOUND AND PANGOCAIRO_FOUND) ) target_include_directories(gvplugin_lasi SYSTEM PRIVATE - ${Freetype_INCLUDE_DIRS} + ${FREETYPE_INCLUDE_DIRS} ${LASI_INCLUDE_DIRS} ${PANGOCAIRO_INCLUDE_DIRS} ) target_link_libraries(gvplugin_lasi - ${Freetype_LIBRARIES} + ${FREETYPE_LIBRARIES} ${LASI_LIBRARIES} ${PANGOCAIRO_LIBRARIES} ) -- 2.40.0