From 558c4367e713871b92e2dc459aab8657bd539601 Mon Sep 17 00:00:00 2001
From: Bruce Momjian <bruce@momjian.us>
Date: Wed, 16 Nov 2005 03:32:04 +0000
Subject: [PATCH] Update error message and documentation for fsync test.

---
 src/tools/fsync/README       |  3 ++-
 src/tools/fsync/test_fsync.c | 34 +++++++++++++++++-----------------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/src/tools/fsync/README b/src/tools/fsync/README
index 570708ed51..f93f649b0e 100644
--- a/src/tools/fsync/README
+++ b/src/tools/fsync/README
@@ -2,4 +2,5 @@ This program tests fsync.  The tests are described as part of the program output
 
 	Usage:	test_fsync [-f filename] [loops]
 
-Loops defaults to 1000.
+Loops defaults to 1000.  The default output file is /var/tmp/test_fsync.out.
+Consider that /tmp or /var/tmp might be memory-based file systems.
diff --git a/src/tools/fsync/test_fsync.c b/src/tools/fsync/test_fsync.c
index 7d65b822c9..7ba648b29f 100644
--- a/src/tools/fsync/test_fsync.c
+++ b/src/tools/fsync/test_fsync.c
@@ -59,7 +59,7 @@ main(int argc, char *argv[])
 		strout[i] = 'a';
 
 	if ((tmpfile = open(filename, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	write(tmpfile, strout, WAL_FILE_SIZE);
 	fsync(tmpfile);				/* fsync so later fsync's don't have to do it */
 	close(tmpfile);
@@ -70,7 +70,7 @@ main(int argc, char *argv[])
 	for (i = 0; i < loops; i++)
 	{
 		if ((tmpfile = open(filename, O_RDWR)) == -1)
-			die("can't open /var/tmp/test_fsync.out");
+			die("Cannot open output file.");
 		write(tmpfile, strout, 8192);
 		close(tmpfile);
 	}
@@ -87,12 +87,12 @@ main(int argc, char *argv[])
 	for (i = 0; i < loops; i++)
 	{
 		if ((tmpfile = open(filename, O_RDWR)) == -1)
-			die("can't open /var/tmp/test_fsync.out");
+			die("Cannot open output file.");
 		write(tmpfile, strout, 8192);
 		fsync(tmpfile);
 		close(tmpfile);
 		if ((tmpfile = open(filename, O_RDWR)) == -1)
-			die("can't open /var/tmp/test_fsync.out");
+			die("Cannot open output file.");
 		/* do nothing but the open/close the tests are consistent. */
 		close(tmpfile);
 	}
@@ -106,12 +106,12 @@ main(int argc, char *argv[])
 	for (i = 0; i < loops; i++)
 	{
 		if ((tmpfile = open(filename, O_RDWR)) == -1)
-			die("can't open /var/tmp/test_fsync.out");
+			die("Cannot open output file.");
 		write(tmpfile, strout, 8192);
 		close(tmpfile);
 		/* reopen file */
 		if ((tmpfile = open(filename, O_RDWR)) == -1)
-			die("can't open /var/tmp/test_fsync.out");
+			die("Cannot open output file.");
 		fsync(tmpfile);
 		close(tmpfile);
 	}
@@ -124,7 +124,7 @@ main(int argc, char *argv[])
 
 	/* 16k o_sync write */
 	if ((tmpfile = open(filename, O_RDWR | OPEN_SYNC_FLAG)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 		write(tmpfile, strout, 16384);
@@ -136,7 +136,7 @@ main(int argc, char *argv[])
 
 	/* 2*8k o_sync writes */
 	if ((tmpfile = open(filename, O_RDWR | OPEN_SYNC_FLAG)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -154,7 +154,7 @@ main(int argc, char *argv[])
 #ifdef OPEN_DATASYNC_FLAG
 	/* open_dsync, write */
 	if ((tmpfile = open(filename, O_RDWR | O_DSYNC)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 		write(tmpfile, strout, 8192);
@@ -169,7 +169,7 @@ main(int argc, char *argv[])
 
 	/* open_fsync, write */
 	if ((tmpfile = open(filename, O_RDWR | OPEN_SYNC_FLAG)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 		write(tmpfile, strout, 8192);
@@ -182,7 +182,7 @@ main(int argc, char *argv[])
 #ifdef HAVE_FDATASYNC
 	/* write, fdatasync */
 	if ((tmpfile = open(filename, O_RDWR)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -200,7 +200,7 @@ main(int argc, char *argv[])
 
 	/* write, fsync, close */
 	if ((tmpfile = open(filename, O_RDWR)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -218,7 +218,7 @@ main(int argc, char *argv[])
 #ifdef OPEN_DATASYNC_FLAG
 	/* open_dsync, write */
 	if ((tmpfile = open(filename, O_RDWR | O_DSYNC)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -236,7 +236,7 @@ main(int argc, char *argv[])
 
 	/* open_fsync, write */
 	if ((tmpfile = open(filename, O_RDWR | OPEN_SYNC_FLAG)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -252,7 +252,7 @@ main(int argc, char *argv[])
 #ifdef HAVE_FDATASYNC
 	/* write, fdatasync */
 	if ((tmpfile = open(filename, O_RDWR)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -271,7 +271,7 @@ main(int argc, char *argv[])
 
 	/* write, fsync, close */
 	if ((tmpfile = open(filename, O_RDWR)) == -1)
-		die("can't open /var/tmp/test_fsync.out");
+		die("Cannot open output file.");
 	gettimeofday(&start_t, NULL);
 	for (i = 0; i < loops; i++)
 	{
@@ -306,6 +306,6 @@ print_elapse(struct timeval start_t, struct timeval elapse_t)
 void
 die(char *str)
 {
-	fprintf(stderr, "%s", str);
+	fprintf(stderr, "%s\n", str);
 	exit(1);
 }
-- 
2.40.0