From 544375f2a6f339e2eb80cf3a6949fe945921c166 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sun, 16 Jan 2022 20:40:37 -0800 Subject: [PATCH] remove Lefty test cases The Lefty tool is deprecated and planned to be removed. 1a4ad00b59cc1e1e9302fcbd1a205495ee59cab5 toggled it to default to disabled in the Autotools build system. The present change is a preparatory commit for dropping explicit re-enabling of it in CI, allowing it to no longer be compiled in CI. --- ci/tests.py | 2 -- rtest/test_regression.py | 13 ------------- rtest/test_tools.py | 1 - 3 files changed, 16 deletions(-) diff --git a/ci/tests.py b/ci/tests.py index dbb01e968..8d76eee96 100644 --- a/ci/tests.py +++ b/ci/tests.py @@ -37,7 +37,6 @@ import pytest "gvpr", "gxl2dot", "gxl2gv", - "lefty", "lneato", "mingle", "mm2gv", @@ -71,7 +70,6 @@ def test_existence(binary: str): "gvmap", "gvmap.sh", "gxl2dot", - "lefty", "lneato", "mingle", "prune", diff --git a/rtest/test_regression.py b/rtest/test_regression.py index e060aab2a..4ae3eac1c 100644 --- a/rtest/test_regression.py +++ b/rtest/test_regression.py @@ -632,19 +632,6 @@ def test_1813(): assert "Usage" in output, "gvedit -? did not show usage" -@pytest.mark.skipif(shutil.which("lefty") is None, reason="Lefty not available") -def test_1818(): - """ - lefty -? should show usage - https://gitlab.com/graphviz/graphviz/-/issues/1813 - """ - - output = subprocess.check_output(["lefty", "-?"], - stderr=subprocess.STDOUT, - universal_newlines=True) - - assert "Usage" in output, "lefty -? did not show usage" - def test_1845(): """ rendering sequential graphs to PS should not segfault diff --git a/rtest/test_tools.py b/rtest/test_tools.py index f7015d3ce..5970dbd12 100644 --- a/rtest/test_tools.py +++ b/rtest/test_tools.py @@ -41,7 +41,6 @@ import pytest "gvpr", "gxl2dot", "gxl2gv", - "lefty", "lneato", "mingle", "mm2gv", -- 2.40.0