From 50b9ef8d9435d23be40cea7fb484a02e99fdb617 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Wed, 5 Sep 2018 21:34:40 +0200 Subject: [PATCH] Remove not needed checking for Header `` is part of the standard C89 headers [1] and on current systems checking is not need anymore since PHP requires at least C89. This is noted also by Autoconf itself in the docs and code [2]. The Autoconf check defined the `HAVE_ERRNO_H` symbol when building PHP with sockets extension or fpm sapi. This symbol is not utilized across the PHP source code except in the current version of bundled GD library which has worked ok so far also with sockets extension or fpm sapi disabled anyway. Refs: [1] https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2 [2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4 --- ext/sockets/config.m4 | 2 +- sapi/fpm/config.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/sockets/config.m4 b/ext/sockets/config.m4 index 277a3a1dcd..525d7c011a 100644 --- a/ext/sockets/config.m4 +++ b/ext/sockets/config.m4 @@ -17,7 +17,7 @@ if test "$PHP_SOCKETS" != "no"; then fi AC_CHECK_FUNCS([hstrerror socketpair if_nametoindex if_indextoname]) - AC_CHECK_HEADERS([netdb.h netinet/tcp.h sys/un.h sys/sockio.h errno.h]) + AC_CHECK_HEADERS([netdb.h netinet/tcp.h sys/un.h sys/sockio.h]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include #include diff --git a/sapi/fpm/config.m4 b/sapi/fpm/config.m4 index 44d842b285..b8e376d92b 100644 --- a/sapi/fpm/config.m4 +++ b/sapi/fpm/config.m4 @@ -11,7 +11,7 @@ AC_DEFUN([AC_FPM_STDLIBS], AC_SEARCH_LIBS(socket, socket) AC_SEARCH_LIBS(inet_addr, nsl) - AC_CHECK_HEADERS([errno.h fcntl.h stdio.h stdlib.h unistd.h sys/uio.h]) + AC_CHECK_HEADERS([fcntl.h stdio.h stdlib.h unistd.h sys/uio.h]) AC_CHECK_HEADERS([sys/select.h sys/socket.h sys/time.h]) AC_CHECK_HEADERS([arpa/inet.h netinet/in.h]) AC_CHECK_HEADERS([sysexits.h]) -- 2.40.0