From 4fbf5a0733026faa62cdf34ee5523313ad88eb19 Mon Sep 17 00:00:00 2001 From: Shane Caraveo Date: Sun, 5 Oct 2003 21:49:47 +0000 Subject: [PATCH] fix crash accessing tagName without namespace --- ext/dom/element.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ext/dom/element.c b/ext/dom/element.c index 063b24e6d5..640eb24dd1 100644 --- a/ext/dom/element.c +++ b/ext/dom/element.c @@ -116,10 +116,12 @@ int dom_element_tag_name_read(dom_object *obj, zval **retval TSRMLS_DC) if (ns != NULL && ns->prefix) { qname = xmlStrdup(ns->prefix); qname = xmlStrcat(qname, ":"); + qname = xmlStrcat(qname, nodep->name); + ZVAL_STRING(*retval, qname, 1); + xmlFree(qname); + } else { + ZVAL_STRING(*retval, nodep->name, 1); } - qname = xmlStrcat(qname, nodep->name); - ZVAL_STRING(*retval, qname, 1); - xmlFree(qname); return SUCCESS; } -- 2.50.1