From 4f46cc67c9d79f4647688a27182df97a43b6d449 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sat, 12 Sep 2020 20:15:51 -0700 Subject: [PATCH] fix resource leakage in graphml2gv This addresses the following Coverity warning: Error: RESOURCE_LEAK (CWE-772): [#def56] graphviz-2.40.1/cmd/tools/graphml2gv.c:729: alloc_fn: Storage is returned from allocation function "openFile". graphviz-2.40.1/cmd/tools/graphml2gv.c:676:5: alloc_fn: Storage is returned from allocation function "fopen". graphviz-2.40.1/cmd/tools/graphml2gv.c:676:5: var_assign: Assigning: "fp" = "fopen(name, mode)". graphviz-2.40.1/cmd/tools/graphml2gv.c:687:5: return_alloc: Returning allocated memory "fp". graphviz-2.40.1/cmd/tools/graphml2gv.c:729: var_assign: Assigning: "outFile" = storage returned from "openFile(optarg, "w")". graphviz-2.40.1/cmd/tools/graphml2gv.c:729: overwrite_var: Overwriting "outFile" in "outFile = openFile(optarg, "w")" leaks the storage that "outFile" points to. # 727| break; # 728| case 'o': # 729|-> outFile = openFile(optarg, "w"); # 730| break; # 731| case ':': Related to #1464. --- cmd/tools/graphml2gv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/tools/graphml2gv.c b/cmd/tools/graphml2gv.c index e2df20ccf..f30463f9d 100644 --- a/cmd/tools/graphml2gv.c +++ b/cmd/tools/graphml2gv.c @@ -723,6 +723,8 @@ static void initargs(int argc, char **argv) Verbose = 1; break; case 'o': + if (outFile != NULL) + fclose(outFile); outFile = openFile(optarg, "w"); break; case ':': -- 2.50.1