From 4ed09f06aa5bbae292fd15dfb6ff9adf283470b0 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Thu, 22 Dec 2016 07:14:33 +0000 Subject: [PATCH] [PM] Remove now-dead extern template and explicit instantiation declarations. We're using a custom class here instead of the helper template, these bits just didn't get deleted when the other bits did get deleted. This was found by a really nice MSVC warning about explicitly instantiating a template where some member functions aren't defined and thus can't be instantiatied. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290327 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Analysis/CGSCCPassManager.h | 5 ----- lib/Analysis/CGSCCPassManager.cpp | 2 -- 2 files changed, 7 deletions(-) diff --git a/include/llvm/Analysis/CGSCCPassManager.h b/include/llvm/Analysis/CGSCCPassManager.h index 8eaa771afce..73f462e4bf1 100644 --- a/include/llvm/Analysis/CGSCCPassManager.h +++ b/include/llvm/Analysis/CGSCCPassManager.h @@ -489,11 +489,6 @@ private: static AnalysisKey Key; }; -// Ensure the \c FunctionAnalysisManagerCGSCCProxy is provided as an extern -// template. -extern template class InnerAnalysisManagerProxy< - FunctionAnalysisManager, LazyCallGraph::SCC, LazyCallGraph &>; - extern template class OuterAnalysisManagerProxy; /// A proxy from a \c CGSCCAnalysisManager to a \c Function. typedef OuterAnalysisManagerProxy diff --git a/lib/Analysis/CGSCCPassManager.cpp b/lib/Analysis/CGSCCPassManager.cpp index 5c1485d02de..2fa258bffea 100644 --- a/lib/Analysis/CGSCCPassManager.cpp +++ b/lib/Analysis/CGSCCPassManager.cpp @@ -25,8 +25,6 @@ template class PassManager; template class OuterAnalysisManagerProxy; -template class InnerAnalysisManagerProxy; template class OuterAnalysisManagerProxy; /// Explicitly specialize the pass manager run method to handle call graph -- 2.49.0