From 4e5a4032df58d697795531374fda4f3f866e87dc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 10 Sep 2015 17:13:31 +0000 Subject: [PATCH] Debug Info: Remove an unnecessary debug type visitor. Thanks to dblaikie for spotting this. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@247303 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/ObjectFilePCHContainerOperations.cpp | 7 ------- test/Modules/ModuleDebugInfo.cpp | 7 ++++--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/CodeGen/ObjectFilePCHContainerOperations.cpp b/lib/CodeGen/ObjectFilePCHContainerOperations.cpp index a850c5ae39..b16544e2e1 100644 --- a/lib/CodeGen/ObjectFilePCHContainerOperations.cpp +++ b/lib/CodeGen/ObjectFilePCHContainerOperations.cpp @@ -70,13 +70,6 @@ class PCHContainerGenerator : public ASTConsumer { return true; } - bool VisitValueDecl(ValueDecl *D) { - QualType QualTy = D->getType(); - if (!QualTy.isNull() && CanRepresent(QualTy.getTypePtr())) - DI.getOrCreateStandaloneType(QualTy, D->getLocation()); - return true; - } - bool VisitObjCInterfaceDecl(ObjCInterfaceDecl *D) { QualType QualTy(D->getTypeForDecl(), 0); if (!QualTy.isNull() && CanRepresent(QualTy.getTypePtr())) diff --git a/test/Modules/ModuleDebugInfo.cpp b/test/Modules/ModuleDebugInfo.cpp index 575fecca72..a23c2459a9 100644 --- a/test/Modules/ModuleDebugInfo.cpp +++ b/test/Modules/ModuleDebugInfo.cpp @@ -7,10 +7,12 @@ // RUN: rm -rf %t // RUN: %clang_cc1 -triple %itanium_abi_triple -x objective-c++ -std=c++11 -g -fmodules -fmodule-format=obj -fimplicit-module-maps -DMODULES -fmodules-cache-path=%t %s -I %S/Inputs -I %t -emit-llvm -o %t.ll -mllvm -debug-only=pchcontainer &>%t-mod.ll // RUN: cat %t-mod.ll | FileCheck %s +// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s // PCH: // RUN: %clang_cc1 -triple %itanium_abi_triple -x c++ -std=c++11 -emit-pch -fmodule-format=obj -I %S/Inputs -o %t.pch %S/Inputs/DebugCXX.h -mllvm -debug-only=pchcontainer &>%t-pch.ll // RUN: cat %t-pch.ll | FileCheck %s +// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s #ifdef MODULES @import DebugCXX; @@ -30,12 +32,11 @@ // CHECK: !DICompositeType(tag: DW_TAG_class_type, // CHECK-SAME: name: "Template >" // CHECK-SAME: identifier: "_ZTSN8DebugCXX8TemplateIfNS_6traitsIfEEEE") -// CHECK: !DICompositeType(tag: DW_TAG_class_type, -// CHECK-SAME: name: "Template >" -// CHECK-SAME: identifier: "_ZTSN8DebugCXX8TemplateIlNS_6traitsIlEEEE") // CHECK: !DICompositeType(tag: DW_TAG_class_type, name: "A" // CHECK-SAME: identifier: "_ZTSN8DebugCXX1AIJvEEE") // CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "FloatInstatiation" // no mangled name here yet. // CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "B", // no mangled name here yet. + +// CHECK-NEG-NOT: "_ZTSN8DebugCXX8TemplateIlNS_6traitsIlEEEE" -- 2.40.0