From 4c4d7261e43c27a2f44c522b5055f3e1ec21eea3 Mon Sep 17 00:00:00 2001 From: Frank Galligan Date: Thu, 4 Dec 2014 16:26:47 -0800 Subject: [PATCH] Fix potential integer overflow. ioc found a potential integer overflow in the rate control. This is related to https://code.google.com/p/webm/issues/detail?id=821 Change-Id: Ib6c4acd6e964972f932fce7490592eb134f2b7ea --- vp9/encoder/vp9_ratectrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vp9/encoder/vp9_ratectrl.c b/vp9/encoder/vp9_ratectrl.c index 37b6718bf..3cc9d9a7b 100644 --- a/vp9/encoder/vp9_ratectrl.c +++ b/vp9/encoder/vp9_ratectrl.c @@ -426,8 +426,8 @@ void vp9_rc_update_rate_correction_factors(VP9_COMP *cpi, int damp_var) { } // Work out a size correction factor. if (projected_size_based_on_q > FRAME_OVERHEAD_BITS) - correction_factor = (100 * cpi->rc.projected_frame_size) / - projected_size_based_on_q; + correction_factor = (int)((100 * (int64_t)cpi->rc.projected_frame_size) / + projected_size_based_on_q); // More heavily damped adjustment used if we have been oscillating either side // of target. -- 2.40.0