From 4b605d2e5a7c4e59abd9f139f267a0ff39645a19 Mon Sep 17 00:00:00 2001
From: Sandro Santilli <strk@keybit.net>
Date: Thu, 1 Mar 2012 19:09:50 +0000
Subject: [PATCH] Add an internal topology._st_mintolerance funtion

This function computes the minimum tolerance for a given geometry.
It works by computing the smallest floating point difference that
could be expressed on any vertex of the geometry.

Currently it's only used to workaround the ST_DWithin/ST_Within
inconsistency (#1625) but could probably be used everytime 0 is
passed as a tolerance, possibly fixing #1641 as well.

git-svn-id: http://svn.osgeo.org/postgis/trunk@9374 b70326c6-7e19-0410-871a-916f4a2858ee
---
 topology/sql/populate.sql.in.c | 35 ++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/topology/sql/populate.sql.in.c b/topology/sql/populate.sql.in.c
index 4c7ec9220..01ee770d9 100644
--- a/topology/sql/populate.sql.in.c
+++ b/topology/sql/populate.sql.in.c
@@ -16,6 +16,30 @@
 
 /* #define POSTGIS_TOPOLOGY_DEBUG 1 */
 
+-- {
+--  Compute the max size of the double-precision floating point grid
+--  cell required to cover the given geometry
+--
+--
+-- A pragmatic test conducted using algoritm shown here:
+-- http://stackoverflow.com/questions/7408407/generate-next-largest-or-smallest-representable-floating-point-number-without-bi
+-- showed the "tolerance" growing by an order of magnitude proportionally
+-- with the order of magnitude of the input, starting with something like
+-- 3.5527136788005009294e-15 for the starting value of 9.0
+--
+-- }{
+CREATE OR REPLACE FUNCTION topology._st_mintolerance(ageom Geometry)
+  RETURNS float8
+AS $$
+    SELECT 3.6 * power(10,  - ( 15 - log(coalesce(
+      nullif(
+        greatest(abs(ST_xmin($1)), abs(ST_ymin($1)),
+                 abs(ST_xmax($1)), abs(ST_ymax($1))),
+        0),
+      1)) ));
+$$ LANGUAGE 'SQL' IMMUTABLE STRICT;
+-- }
+
 --{
 --
 -- AddNode(atopology, point, allowEdgeSplitting, setContainingFace)
@@ -700,16 +724,7 @@ BEGIN
       -- and small enough to snap only to the projected point.
       -- Unfortunately ST_Distance returns 0 because it also uses
       -- a projected point internally, so we need another way.
-      --
-      -- A pragmatic test conducted using algoritm shown here:
-      -- http://stackoverflow.com/questions/7408407/generate-next-largest-or-smallest-representable-floating-point-number-without-bi
-      -- showed the "tolerance" growing by an order of magnitude proportionally
-      -- with the order of magnitude of the input, starting with something like
-      -- 3.5527136788005009294e-15 for the starting value of 9.0
-      --
-      -- TODO: make this simpler
-      --
-      snaptol := 3.6 * power(10,  - ( 15 - log(10.0, coalesce(nullif(greatest(abs(ST_X(prj)), abs(ST_Y(prj)))::numeric, 0), 1)) ));
+      snaptol := topology._st_mintolerance(prj);
 #ifdef POSTGIS_TOPOLOGY_DEBUG
       RAISE DEBUG 'Tolerance for snapping to point % = %', ST_AsText(prj), snaptol;
 #endif
-- 
2.40.0