From 4af02cb0834063c92040a20a0fe54c758530d42f Mon Sep 17 00:00:00 2001 From: nekral-guest Date: Mon, 31 Dec 2007 14:37:24 +0000 Subject: [PATCH] Avoid assignments in comparisons. --- src/chfn.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/chfn.c b/src/chfn.c index 6607cb09..3baea8f8 100644 --- a/src/chfn.c +++ b/src/chfn.c @@ -210,7 +210,8 @@ static char *copy_field (char *in, char *out, char *extra) char *cp = NULL; while (NULL != in) { - if ((cp = strchr (in, ',')) != NULL) { + cp = strchr (in, ','); + if (NULL != cp) { *cp++ = '\0'; } -- 2.50.1