From 49e181eff180388e437ce08577e5fd8a69c8b77d Mon Sep 17 00:00:00 2001 From: Greg Beaver Date: Wed, 9 Jan 2008 06:45:36 +0000 Subject: [PATCH] fix Bug #43793: zlib filter is unable to auto-detect gzip/zlib file headers --- ext/zlib/tests/zlib_filter_inflate2.phpt | 41 ++++++++++++++++++++++++ ext/zlib/zlib_filter.c | 2 +- 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 ext/zlib/tests/zlib_filter_inflate2.phpt diff --git a/ext/zlib/tests/zlib_filter_inflate2.phpt b/ext/zlib/tests/zlib_filter_inflate2.phpt new file mode 100644 index 0000000000..4332d8e5e6 --- /dev/null +++ b/ext/zlib/tests/zlib_filter_inflate2.phpt @@ -0,0 +1,41 @@ +--TEST-- +zlib.inflate of gzip-encoded stream +--SKIPIF-- + +--FILE-- + 15+16)); +echo "2\n"; +echo fread($fp, 2000); +fclose($fp); +// auto-detect +$fp = fopen(dirname(__FILE__) . '/test.txt.gz', 'r'); +stream_filter_append($fp, 'zlib.inflate', STREAM_FILTER_READ, array('window' => 15+32)); +echo "3\n"; +echo fread($fp, 2000); +fclose($fp); + +?> +--CLEAN-- + +--EXPECT-- +1 +2 +This is quite the thing ain't it +3 +This is quite the thing ain't it \ No newline at end of file diff --git a/ext/zlib/zlib_filter.c b/ext/zlib/zlib_filter.c index 6460607db9..dc4432f70a 100644 --- a/ext/zlib/zlib_filter.c +++ b/ext/zlib/zlib_filter.c @@ -323,7 +323,7 @@ static php_stream_filter *php_zlib_filter_create(const char *filtername, zval *f /* log-2 base of history window (9 - 15) */ SEPARATE_ZVAL(tmpzval); convert_to_long_ex(tmpzval); - if (Z_LVAL_PP(tmpzval) < -MAX_WBITS || Z_LVAL_PP(tmpzval) > MAX_WBITS) { + if (Z_LVAL_PP(tmpzval) < -MAX_WBITS || Z_LVAL_PP(tmpzval) > MAX_WBITS + 32) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid parameter give for window size. (%ld)", Z_LVAL_PP(tmpzval)); } else { windowBits = Z_LVAL_PP(tmpzval); -- 2.40.0