From 4907faecd126f0f03f7962d67f671b47f258e600 Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Sun, 16 Nov 2008 18:00:50 +0000 Subject: [PATCH] Fixed memory leak inside readline_callback_handler_install() function --- ext/readline/readline.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ext/readline/readline.c b/ext/readline/readline.c index f1e94cb662..7f08e8a981 100644 --- a/ext/readline/readline.c +++ b/ext/readline/readline.c @@ -187,7 +187,7 @@ PHP_RSHUTDOWN_FUNCTION(readline) #if HAVE_RL_CALLBACK_READ_CHAR if (_prepped_callback) { rl_callback_handler_remove(); - FREE_ZVAL(_prepped_callback); + zval_ptr_dtor(&_prepped_callback); _prepped_callback = 0; } #endif @@ -556,10 +556,11 @@ PHP_FUNCTION(readline_callback_handler_install) efree(name); RETURN_FALSE; } + efree(name); if (_prepped_callback) { rl_callback_handler_remove(); - FREE_ZVAL(_prepped_callback); + zval_ptr_dtor(&_prepped_callback); } MAKE_STD_ZVAL(_prepped_callback); -- 2.50.1