From 47fe4684ff61a8ea5cc77147fe9409a8d612bfb6 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Fri, 15 Nov 2013 20:39:33 +0000 Subject: [PATCH] Issue #19523: Closed FileHandler leak which occurred when delay was set. --- Lib/logging/__init__.py | 4 +++- Misc/NEWS | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py index cda781a489..9548e22463 100644 --- a/Lib/logging/__init__.py +++ b/Lib/logging/__init__.py @@ -912,8 +912,10 @@ class FileHandler(StreamHandler): self.flush() if hasattr(self.stream, "close"): self.stream.close() - StreamHandler.close(self) self.stream = None + # Issue #19523: call unconditionally to + # prevent a handler leak when delay is set + StreamHandler.close(self) finally: self.release() diff --git a/Misc/NEWS b/Misc/NEWS index f60af40c2f..2638fc766e 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -12,6 +12,8 @@ Core and Builtins Library ------- +- Issue #19523: Closed FileHandler leak which occurred when delay was set. + - Issue #1575020: Fixed support of 24-bit wave files on big-endian platforms. - Issue #19480: HTMLParser now accepts all valid start-tag names as defined -- 2.50.1