From 478c70f6d2c1f83d4c4e82ced533e71d9e19ef32 Mon Sep 17 00:00:00 2001 From: Sarah Parker Date: Thu, 10 Sep 2020 20:33:02 -0700 Subject: [PATCH] googletest: enable failure on uninstantiated tests Similar to the change in https://aomedia-review.googlesource.com/c/aom/+/115162. This currently is a warning, but the tree should be clean now in the default x86-64 configuration so we can use it to prevent regressions and find any remaining issues in other configurations. BUG=b/159031844 Change-Id: I097537ff018668492d37164fdba5edd241dc5dbe --- third_party/googletest/README.libvpx | 2 ++ third_party/googletest/src/src/gtest.cc | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/third_party/googletest/README.libvpx b/third_party/googletest/README.libvpx index 0f6202cb7..ed55fb09f 100644 --- a/third_party/googletest/README.libvpx +++ b/third_party/googletest/README.libvpx @@ -19,3 +19,5 @@ Local Modifications: LICENSE README.md src +- Enable kErrorOnUninstantiatedParameterizedTest and + kErrorOnUninstantiatedTypeParameterizedTest in gtest.cc diff --git a/third_party/googletest/src/src/gtest.cc b/third_party/googletest/src/src/gtest.cc index 095778e6e..b8f6a5c31 100644 --- a/third_party/googletest/src/src/gtest.cc +++ b/third_party/googletest/src/src/gtest.cc @@ -414,8 +414,8 @@ namespace { // inserted to report ether an error or a log message. // // This configuration bit will likely be removed at some point. -constexpr bool kErrorOnUninstantiatedParameterizedTest = false; -constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = false; +constexpr bool kErrorOnUninstantiatedParameterizedTest = true; +constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = true; // A test that fails at a given file/line location with a given message. class FailureTest : public Test { -- 2.40.0