From 477bd49ccab2a10c421a51f512d593251ef7adef Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Mon, 7 Jul 2014 18:09:17 +0400 Subject: [PATCH] Wrong expectation in tests (for some reason backtraces contained invlalid extra frame at the top) --- .../errors/non_ref_generator_iterated_by_ref_error.phpt | 3 +-- Zend/tests/generators/generator_rewind.phpt | 3 +-- Zend/zend_builtin_functions.c | 1 + ext/soap/tests/bugs/bug54911.phpt | 9 ++++----- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Zend/tests/generators/errors/non_ref_generator_iterated_by_ref_error.phpt b/Zend/tests/generators/errors/non_ref_generator_iterated_by_ref_error.phpt index de5b22f6ba..7878369591 100644 --- a/Zend/tests/generators/errors/non_ref_generator_iterated_by_ref_error.phpt +++ b/Zend/tests/generators/errors/non_ref_generator_iterated_by_ref_error.phpt @@ -12,7 +12,6 @@ foreach ($gen as &$value) { } --EXPECTF-- Fatal error: Uncaught exception 'Exception' with message 'You can only iterate a generator by-reference if it declared that it yields by-reference' in %s:%d Stack trace: -#0 %s(%d): unknown() -#1 {main} +#0 {main} thrown in %s on line %d diff --git a/Zend/tests/generators/generator_rewind.phpt b/Zend/tests/generators/generator_rewind.phpt index c4b5bbbdf4..f5452a7113 100644 --- a/Zend/tests/generators/generator_rewind.phpt +++ b/Zend/tests/generators/generator_rewind.phpt @@ -56,7 +56,6 @@ Stack trace: exception 'Exception' with message 'Cannot traverse an already closed generator' in %s:%d Stack trace: -#0 %s(%d): unknown() -#1 {main} +#0 {main} in generator diff --git a/Zend/zend_builtin_functions.c b/Zend/zend_builtin_functions.c index 96b339cd67..216a67a090 100644 --- a/Zend/zend_builtin_functions.c +++ b/Zend/zend_builtin_functions.c @@ -2253,6 +2253,7 @@ ZEND_API void zend_fetch_debug_backtrace(zval *return_value, int skip_last, int } if (!call) { call = ptr; + ptr = ptr->prev_execute_data; } array_init(return_value); diff --git a/ext/soap/tests/bugs/bug54911.phpt b/ext/soap/tests/bugs/bug54911.phpt index 1a2d6eeb7e..6913925f8a 100644 --- a/ext/soap/tests/bugs/bug54911.phpt +++ b/ext/soap/tests/bugs/bug54911.phpt @@ -15,8 +15,7 @@ Bug #54911 (Access to a undefined member in inherit SoapClient may cause Segment --EXPECTF-- Fatal error: Uncaught SoapFault exception: [Client] Access to undeclared static property: XSoapClient::$crash in %sbug54911.php:4 Stack trace: -#0 %sbug54911.php(4): XSoapClient->__doRequest() -#1 [internal function]: XSoapClient->__doRequest('__soapCall('', Array) -#3 {main} - thrown in %sbug54911.php on line 4 \ No newline at end of file +#0 [internal function]: XSoapClient->__doRequest('__soapCall('', Array) +#2 {main} + thrown in %sbug54911.php on line 4 -- 2.40.0