From 4726c35ca33da837406745f21e2320fb18ae7618 Mon Sep 17 00:00:00 2001 From: Matteo Beccati Date: Fri, 29 Mar 2019 14:24:09 +0100 Subject: [PATCH] Removed declaration inside for loops --- ext/mbstring/mbstring.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c index 48436550a4..cf0b08be6e 100644 --- a/ext/mbstring/mbstring.c +++ b/ext/mbstring/mbstring.c @@ -2367,7 +2367,9 @@ PHP_FUNCTION(mb_str_split) while (p < last) { /* split cycle work until the cursor has reached the last byte */ char const *chunk_p = p; /* chunk first byte pointer */ chunk_len = 0; /* chunk length in bytes */ - for (zend_long char_count = 0; char_count < split_length && p < last; ++char_count) { + zend_long char_count; + + for (char_count = 0; char_count < split_length && p < last; ++char_count) { char unsigned const m = mbtab[*(const unsigned char *)p]; /* single character length table */ chunk_len += m; p += m; @@ -2435,7 +2437,9 @@ PHP_FUNCTION(mb_str_split) chunks = (mb_len + split_length - 1) / split_length; /* (round up idiom) */ array_init_size(return_value, chunks); if (chunks != 0) { - for (zend_long i = 0; i < chunks - 1; p += chunk_len, ++i) { + zend_long i; + + for (i = 0; i < chunks - 1; p += chunk_len, ++i) { add_next_index_stringl(return_value, p, chunk_len); } add_next_index_stringl(return_value, p, last - p); -- 2.50.1