From 46db4b27f2d685cdfa47c47bdd5ef57e4349c824 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Sat, 3 Dec 2016 22:25:21 +0000 Subject: [PATCH] AMDGPU: remove a couple of unused variables lib/Target/AMDGPU/SIRegisterInfo.cpp: In member function 'void llvm::SIRegisterInfo::spillSGPR(llvm::MachineBasicBlock::iterator, int, llvm::RegScavenger*) const': lib/Target/AMDGPU/SIRegisterInfo.cpp:572:30: warning: variable 'SubRC' set but not used [-Wunused-but-set-variable] const TargetRegisterClass *SubRC = nullptr; ^ lib/Target/AMDGPU/SIRegisterInfo.cpp: In member function 'void llvm::SIRegisterInfo::restoreSGPR(llvm::MachineBasicBlock::iterator, int, llvm::RegScavenger*) const': lib/Target/AMDGPU/SIRegisterInfo.cpp:723:30: warning: variable 'SubRC' set but not used [-Wunused-but-set-variable] const TargetRegisterClass *SubRC = nullptr; ^ The variable was assigned to, but never used. The functions called did not mutate state. Simplify the logic and remove the variable. Identified by gcc 5.4.0. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@288601 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/AMDGPU/SIRegisterInfo.cpp | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/lib/Target/AMDGPU/SIRegisterInfo.cpp b/lib/Target/AMDGPU/SIRegisterInfo.cpp index 3c96cc2d7ca..2898f68ead2 100644 --- a/lib/Target/AMDGPU/SIRegisterInfo.cpp +++ b/lib/Target/AMDGPU/SIRegisterInfo.cpp @@ -569,14 +569,8 @@ void SIRegisterInfo::spillSGPR(MachineBasicBlock::iterator MI, std::tie(EltSize, ScalarStoreOp) = getSpillEltSize(RC->getSize(), true); } - const TargetRegisterClass *SubRC = nullptr; - unsigned NumSubRegs = 1; ArrayRef SplitParts = getRegSplitParts(RC, EltSize); - - if (!SplitParts.empty()) { - NumSubRegs = SplitParts.size(); - SubRC = getSubRegClass(RC, SplitParts[0]); - } + unsigned NumSubRegs = SplitParts.empty() ? 1 : SplitParts.size(); // SubReg carries the "Kill" flag when SubReg == SuperReg. unsigned SubKillState = getKillRegState((NumSubRegs == 1) && IsKill); @@ -720,14 +714,8 @@ void SIRegisterInfo::restoreSGPR(MachineBasicBlock::iterator MI, std::tie(EltSize, ScalarLoadOp) = getSpillEltSize(RC->getSize(), false); } - const TargetRegisterClass *SubRC = nullptr; - unsigned NumSubRegs = 1; ArrayRef SplitParts = getRegSplitParts(RC, EltSize); - - if (!SplitParts.empty()) { - NumSubRegs = SplitParts.size(); - SubRC = getSubRegClass(RC, SplitParts[0]); - } + unsigned NumSubRegs = SplitParts.empty() ? 1 : SplitParts.size(); // SubReg carries the "Kill" flag when SubReg == SuperReg. int64_t FrOffset = FrameInfo.getObjectOffset(Index); -- 2.50.1