From 45d7ab1a4c323c50bc5007cf826540e62693db8c Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Fri, 30 May 2014 11:12:03 +0400 Subject: [PATCH] Avoid in-place modification --- ext/simplexml/simplexml.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c index f9f7452bf4..1bcfec361a 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -530,7 +530,12 @@ static int sxe_prop_dim_write(zval *object, zval *member, zval *value, zend_bool case IS_TRUE: case IS_DOUBLE: case IS_NULL: - convert_to_string(value); + if (Z_TYPE_P(value) != IS_STRING) { + ZVAL_DUP(&zval_copy, value); + value = &zval_copy; + convert_to_string(value); + new_value = 1; + } break; case IS_STRING: break; -- 2.50.1