From 459951bc36e012b8279ee5878d61769786a42c37 Mon Sep 17 00:00:00 2001 From: Younies Mahmoud Date: Wed, 18 Mar 2020 13:46:52 +0100 Subject: [PATCH] address Shane's comments on number_formatter.h --- icu4c/source/i18n/unicode/numberformatter.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/icu4c/source/i18n/unicode/numberformatter.h b/icu4c/source/i18n/unicode/numberformatter.h index 5e13d594ec3..e4740055fd0 100644 --- a/icu4c/source/i18n/unicode/numberformatter.h +++ b/icu4c/source/i18n/unicode/numberformatter.h @@ -2047,8 +2047,7 @@ class U_I18N_API NumberFormatterSettings { Derived scale(const Scale &scale) &&; /** - * Specifies the usage of the unit ("length-person", "length-road", - * "mass-person" ...etc.) + * Specifies the usage of the unit ("person", "road", "person" ...etc.) * *

* NOTE: `usage` will change the output unit depending on the `Locale` @@ -2064,19 +2063,18 @@ class U_I18N_API NumberFormatterSettings { *

* *

- * If the input usage is not exist (e.g. length-dinosaur) or is - * misspelled, the output unit **will not change**. + * If the input usage is not exist (e.g. "dance") or is misspelled, + * the usage will be **fall backed** to the "default" usage. *

* * Pass this method a `StringPiece` that represents the usage of * the unit. For example: * *
-     * NumberFormatter::with().usage("length-person")
+     * NumberFormatter::with().usage("person")
      * 
* - * @param usage - * The unit `usage`. + * @param usage The unit `usage`. * @return The fluent chain. * @draft ICU 67 */ @@ -2085,8 +2083,7 @@ class U_I18N_API NumberFormatterSettings { /** * Overload of usage() for use on an rvalue reference. * - * @param usage - * The unit `usage`. + * @param usage The unit `usage`. * @return The fluent chain. * @draft ICU 67 */ -- 2.40.0