From 44cd47c1d49655c5dd9648bde8e267617c3735b4 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 17 May 2014 18:29:46 -0400 Subject: [PATCH] Make fallback implementation of pg_memory_barrier() work. The fallback implementation involves acquiring and releasing a spinlock variable that is otherwise unreferenced --- not even to the extent of initializing it. This accidentally fails to fail on platforms where spinlocks should be initialized to zeroes, but elsewhere it results in a "stuck spinlock" failure during startup. I griped about this last July, and put in a hack that worked for gcc on HPPA, but didn't get around to fixing the general case. Per the discussion back then, the best thing to do seems to be to initialize dummy_spinlock in main.c. --- src/backend/main/main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/backend/main/main.c b/src/backend/main/main.c index 4a563741e9..c6fb8c9fbe 100644 --- a/src/backend/main/main.c +++ b/src/backend/main/main.c @@ -37,6 +37,8 @@ #include "bootstrap/bootstrap.h" #include "common/username.h" #include "postmaster/postmaster.h" +#include "storage/barrier.h" +#include "storage/spin.h" #include "tcop/tcopprot.h" #include "utils/help_config.h" #include "utils/memutils.h" @@ -288,6 +290,12 @@ startup_hacks(const char *progname) SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX); } #endif /* WIN32 */ + + /* + * Initialize dummy_spinlock, in case we are on a platform where we have + * to use the fallback implementation of pg_memory_barrier(). + */ + SpinLockInit(&dummy_spinlock); } -- 2.40.0