From 44a3d32b7eda8812b249c61ed54aa37731b672e2 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Sat, 26 Feb 2022 11:01:57 -0800 Subject: [PATCH] expr: [nfc] remove unnecessary parens and dereference of 'setf' The C compiler knows how to dereference and call through a function pointer without needing this manual instruction. --- lib/expr/exeval.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c index ac27d3820..366153f41 100644 --- a/lib/expr/exeval.c +++ b/lib/expr/exeval.c @@ -1209,7 +1209,9 @@ eval(Expr_t* ex, Exnode_t* expr, void* env) locv = getdyn(ex, x->data.variable.dyna, env, &assoc); x->data.variable.dyna->data.variable.dyna->data.constant.value = locv; } - if ((*ex->disc->setf)(ex, x, x->data.variable.symbol, x->data.variable.reference, env, (int)i.integer, v, ex->disc) < 0) + if (ex->disc->setf(ex, x, x->data.variable.symbol, + x->data.variable.reference, env, (int)i.integer, v, + ex->disc) < 0) exerror("%s: cannot set value", x->data.variable.symbol->name); } if (expr->subop == PRE) -- 2.40.0