From 44940eda85fa8db75752b7c7506b3b74e88ea2bc Mon Sep 17 00:00:00 2001 From: Dmitri Gribenko Date: Wed, 17 Apr 2019 06:11:27 +0000 Subject: [PATCH] Fixed error message printing in write_cmake_config.py Summary: Previously, write_cmake_config.py would raise an error while printing the error, because `leftovers` in "'\n'.join(leftovers)" is a tuple. Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D60766 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358557 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/gn/build/write_cmake_config.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils/gn/build/write_cmake_config.py b/utils/gn/build/write_cmake_config.py index eba6b4ec521..d57435285d1 100755 --- a/utils/gn/build/write_cmake_config.py +++ b/utils/gn/build/write_cmake_config.py @@ -96,7 +96,10 @@ def main(): leftovers = var_re.findall(output) if leftovers: - print('unprocessed values:\n', '\n'.join(leftovers), file=sys.stderr) + print( + 'unprocessed values:\n', + '\n'.join([x[0] or x[1] for x in leftovers]), + file=sys.stderr) return 1 if not os.path.exists(args.output) or open(args.output).read() != output: -- 2.50.1