From 445844993b68f102241a600636b0d69394db1c7b Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sat, 3 Dec 2016 11:01:50 -0800 Subject: [PATCH] fix refleak in the shift-by-zero case (#27870) --- Objects/longobject.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Objects/longobject.c b/Objects/longobject.c index b87546eb6c..768a92a941 100644 --- a/Objects/longobject.c +++ b/Objects/longobject.c @@ -3710,14 +3710,15 @@ long_lshift(PyObject *v, PyObject *w) shiftby = PyLong_AsSsize_t((PyObject *)b); if (shiftby == -1L && PyErr_Occurred()) - goto lshift_error; + goto out; if (shiftby < 0) { PyErr_SetString(PyExc_ValueError, "negative shift count"); - goto lshift_error; + goto out; } if (Py_SIZE(a) == 0) { - return PyLong_FromLong(0); + z = (PyLongObject *)PyLong_FromLong(0); + goto out; } /* wordshift, remshift = divmod(shiftby, PyLong_SHIFT) */ @@ -3730,7 +3731,7 @@ long_lshift(PyObject *v, PyObject *w) ++newsize; z = _PyLong_New(newsize); if (z == NULL) - goto lshift_error; + goto out; if (a->ob_size < 0) z->ob_size = -(z->ob_size); for (i = 0; i < wordshift; i++) @@ -3746,7 +3747,7 @@ long_lshift(PyObject *v, PyObject *w) else assert(!accum); z = long_normalize(z); - lshift_error: + out: Py_DECREF(a); Py_DECREF(b); return (PyObject *) z; -- 2.50.1