From 4433199fc1e7ccfae7e919dd3ae6b2fe9e7780f8 Mon Sep 17 00:00:00 2001
From: Luca Toscano <elukey@apache.org>
Date: Sat, 23 Jun 2018 13:12:09 +0000
Subject: [PATCH] mod_proxy.xml: clarify the usage of variable interpolation

PR: 62477


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1834203 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/manual/mod/mod_proxy.xml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/docs/manual/mod/mod_proxy.xml b/docs/manual/mod/mod_proxy.xml
index 96c513e111..7d2f4b9c6b 100644
--- a/docs/manual/mod/mod_proxy.xml
+++ b/docs/manual/mod/mod_proxy.xml
@@ -1437,9 +1437,10 @@ ProxyPass "/" "balancer://hotcluster/"
     environment variables will not exist when this interpolation happens,
     so you may still have to resort to <module>mod_rewrite</module>
     for complex rules.  Also note that interpolation is not supported
-    within the scheme portion of a URL.  Dynamic determination of the
-    scheme can be accomplished with <module>mod_rewrite</module> as in the
-    following example.</p>
+    within the scheme/hostname/port portion of a URL. Dynamic determination of
+    those fields can be accomplished with <module>mod_rewrite</module>.
+    The following example describes how to use <module>mod_rewrite</module>
+    to dynamically set the scheme to http or https:</p>
 
     <highlight language="config">
 RewriteEngine On
@@ -2052,7 +2053,12 @@ header for proxied requests</description>
     and causes them to substitute the value of an environment
     variable <code>varname</code> for the string <code>${varname}</code>
     in configuration directives if the <var>interpolate</var> option is set.</p>
-    <p>Keep this turned off (for server performance) unless you need it!</p>
+    <p>The scheme/hostname/port portion of <directive>ProxyPass</directive> cannot
+    contain variables, please consider using <module>mod_rewrite</module> instead.</p>
+    <p>Keep this turned off (for server performance) unless you need it!
+    Adding variables to <directive>ProxyPass</directive> for example may lead to
+    using the default mod_proxy's workers configured (that don't allow any fine
+    tuning like connections reuse, etc..).</p>
 </usage>
 </directivesynopsis>
 
-- 
2.50.1