From 4400fb3ea378b40bbffe55bf8bc8fe39e980485b Mon Sep 17 00:00:00 2001 From: Christophe Jaillet Date: Fri, 9 Jan 2015 20:37:50 +0000 Subject: [PATCH] Merge r1644503 from trunk * mod_proxy_ajp: Fix handling of the default port (8009) in the ProxyPass and configurations. PR 57259. Submitted by: ylavic Reviewed by: ylavic, jim, covener Backported by: jailletc36 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1650655 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 3 +++ STATUS | 6 ------ modules/proxy/proxy_util.c | 16 ++++++++++++++++ 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/CHANGES b/CHANGES index ec5e74f30d..e85df51f2b 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,9 @@ Changes with Apache 2.4.11 request headers earlier. Adds "MergeTrailers" directive to restore legacy behavior. [Edward Lu, Yann Ylavic, Joe Orton, Eric Covener] + *) mod_proxy_ajp: Fix handling of the default port (8009) in the + ProxyPass and configurations. PR 57259. [Yann Ylavic]. + *) mpm_event: Avoid a possible use after free when notifying the end of connection during lingering close. PR 57268. [Eric Covener, Yann Ylavic] diff --git a/STATUS b/STATUS index 42f2ecbf13..a4419f9c7d 100644 --- a/STATUS +++ b/STATUS @@ -104,12 +104,6 @@ RELEASE SHOWSTOPPERS: PATCHES ACCEPTED TO BACKPORT FROM TRUNK: [ start all new proposals below, under PATCHES PROPOSED. ] - * mod_proxy_ajp: Fix handling of the default port (8009) in the - ProxyPass and configurations. PR 57259. - trunk patch: http://svn.apache.org/r1644503 - 2.4.x patch: trunk works (module CHANGES) - +1: ylavic, jim, covener - * mod_ssl: Check if we are having an SSL connection before looking up SSL related variables during expression evaluation to avoid a crash. If not return NULL as ssl_var_lookup_ssl does by default. PR 57070 diff --git a/modules/proxy/proxy_util.c b/modules/proxy/proxy_util.c index 060b98f866..1d3b8c0aa4 100644 --- a/modules/proxy/proxy_util.c +++ b/modules/proxy/proxy_util.c @@ -1683,6 +1683,9 @@ PROXY_DECLARE(char *) ap_proxy_define_worker(apr_pool_t *p, memset(wshared, 0, sizeof(proxy_worker_shared)); + if (uri.port && uri.port == ap_proxy_port_of_scheme(uri.scheme)) { + uri.port = 0; + } ptr = apr_uri_unparse(p, &uri, APR_URI_UNP_REVEALPASSWORD); if (PROXY_STRNCPY(wshared->name, ptr) != APR_SUCCESS) { ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO(02808) @@ -2657,6 +2660,13 @@ PROXY_DECLARE(int) ap_proxy_connect_backend(const char *proxy_function, worker->s->hostname); break; } + + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(02823) + "%s: connection established with Unix domain socket " + "%s (%s)", + proxy_function, + conn->uds_path, + worker->s->hostname); } else #endif @@ -2749,6 +2759,12 @@ PROXY_DECLARE(int) ap_proxy_connect_backend(const char *proxy_function, backend_addr = backend_addr->next; continue; } + + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(02824) + "%s: connection established with %pI (%s)", + proxy_function, + backend_addr, + worker->s->hostname); } /* Set a timeout on the socket */ -- 2.40.0