From 43aa40e1551b9e8d30b376de6d6a9b976ae54332 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Thu, 21 Jul 2011 17:12:35 -0400 Subject: [PATCH] In pg_upgrade, add C comment about why we don't try to do shared file writes for logging. --- contrib/pg_upgrade/pg_upgrade.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h index df884bd684..6def748ae8 100644 --- a/contrib/pg_upgrade/pg_upgrade.h +++ b/contrib/pg_upgrade/pg_upgrade.h @@ -207,6 +207,10 @@ typedef struct * because it is being used by another process." so we have to send all * other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and * it equals 'filename' on all other platforms. + * + * We could use the Windows pgwin32_open() flags to allow shared file + * writes but is unclear how all other tools would use those flags, so + * we just avoid it and log a little less on Windows. */ char *filename2; FILE *fd; /* log FILE */ -- 2.40.0