From 4094031dd3392b2f49b190a5617d0c247167bcf6 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 28 Apr 2018 11:46:15 -0400 Subject: [PATCH] Assorted minor doc/comment fixes. Identify pg_replication_origin as a shared catalog in catalogs.sgml, using the same boilerplate wording used for most other shared catalogs (and tweak another place where someone had randomly deviated from that boilerplate). Make an example in mmgr/README more consistent with surrounding text. Update an obsolete cross-reference in a comment in storage/block.h. Zhuo Ql Discussion: https://postgr.es/m/44296255.1819230.1524889719001@mail.yahoo.com --- doc/src/sgml/catalogs.sgml | 9 ++++++++- src/backend/utils/mmgr/README | 2 +- src/include/storage/block.h | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 14aeed3076..26984b6cba 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -5690,6 +5690,13 @@ SCRAM-SHA-256$<iteration count>:&l see . + + Unlike most system catalogs, pg_replication_origin + is shared across all databases of a cluster: there is only one copy + of pg_replication_origin per cluster, not one per + database. + + <structname>pg_replication_origin</structname> Columns @@ -6608,7 +6615,7 @@ SCRAM-SHA-256$<iteration count>:&l Unlike most system catalogs, pg_subscription is - shared across all databases of a cluster: There is only one copy + shared across all databases of a cluster: there is only one copy of pg_subscription per cluster, not one per database. diff --git a/src/backend/utils/mmgr/README b/src/backend/utils/mmgr/README index a42e568d5c..7e6541d0de 100644 --- a/src/backend/utils/mmgr/README +++ b/src/backend/utils/mmgr/README @@ -401,7 +401,7 @@ GetMemoryChunkContext()) and then invoke the corresponding method for the context - context->methods->free_p(p); + context->methods->free_p(pointer); More Control Over aset.c Behavior diff --git a/src/include/storage/block.h b/src/include/storage/block.h index e2bfa11e37..182aa8d453 100644 --- a/src/include/storage/block.h +++ b/src/include/storage/block.h @@ -22,7 +22,7 @@ * contains exactly one disk block). the blocks are numbered * sequentially, 0 to 0xFFFFFFFE. * - * InvalidBlockNumber is the same thing as P_NEW in buf.h. + * InvalidBlockNumber is the same thing as P_NEW in bufmgr.h. * * the access methods, the buffer manager and the storage manager are * more or less the only pieces of code that should be accessing disk -- 2.40.0