From 40249e7487c3314f185c63302aaad9edde6dfd53 Mon Sep 17 00:00:00 2001 From: John McCall Date: Tue, 1 Feb 2011 23:28:01 +0000 Subject: [PATCH] When diagnosing address-space changes, apply array-to-pointer decay first. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@124702 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExpr.cpp | 3 +++ test/Sema/address_spaces.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index ab190276af..c084bb0a80 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -8690,6 +8690,9 @@ bool Sema::DiagnoseAssignmentResult(AssignConvertType ConvTy, DiagKind = diag::ext_typecheck_convert_pointer_void_func; break; case IncompatiblePointerDiscardsQualifiers: { + // Perform array-to-pointer decay if necessary. + if (SrcType->isArrayType()) SrcType = Context.getArrayDecayedType(SrcType); + Qualifiers lhq = SrcType->getPointeeType().getQualifiers(); Qualifiers rhq = DstType->getPointeeType().getQualifiers(); if (lhq.getAddressSpace() != rhq.getAddressSpace()) { diff --git a/test/Sema/address_spaces.c b/test/Sema/address_spaces.c index 38b51b2912..a53bb4da00 100644 --- a/test/Sema/address_spaces.c +++ b/test/Sema/address_spaces.c @@ -39,3 +39,8 @@ void * get_0(void) { return base[0]; // expected-error {{returning '__attribute__((address_space(256))) void *' from a function with result type 'void *' changes address space of pointer}} } +__attribute__((address_space(1))) char test3_array[10]; +void test3(void) { + extern void test3_helper(char *p); // expected-note {{passing argument to parameter 'p' here}} + test3_helper(test3_array); // expected-error {{changes address space of pointer}} +} -- 2.40.0