From 3fbf99a28335757dcc1a285486c6fa32a0cc236a Mon Sep 17 00:00:00 2001 From: Antony Dovgal Date: Wed, 2 Apr 2008 14:56:03 +0000 Subject: [PATCH] decrement parent's refcount only when destroying the child, not when decrementing child's refcount --- ext/oci8/oci8_interface.c | 4 ---- ext/oci8/oci8_statement.c | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ext/oci8/oci8_interface.c b/ext/oci8/oci8_interface.c index 419327cfe1..b1477b4b32 100644 --- a/ext/oci8/oci8_interface.c +++ b/ext/oci8/oci8_interface.c @@ -1550,10 +1550,6 @@ PHP_FUNCTION(oci_free_statement) PHP_OCI_ZVAL_TO_STATEMENT(z_statement, statement); zend_list_delete(statement->id); - if (statement->parent_stmtid) { - zend_list_delete(statement->parent_stmtid); - } - RETURN_TRUE; } /* }}} */ diff --git a/ext/oci8/oci8_statement.c b/ext/oci8/oci8_statement.c index 8963ada2c5..1002b4885e 100644 --- a/ext/oci8/oci8_statement.c +++ b/ext/oci8/oci8_statement.c @@ -780,7 +780,11 @@ void php_oci_statement_free(php_oci_statement *statement TSRMLS_DC) zend_hash_destroy(statement->defines); efree(statement->defines); } - + + if (statement->parent_stmtid) { + zend_list_delete(statement->parent_stmtid); + } + zend_list_delete(statement->connection->rsrc_id); efree(statement); -- 2.50.1