From 3f75e422be7dba58a6c6fc58dcc51b882bd4adaf Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Mon, 11 Nov 2013 01:29:22 +0100 Subject: [PATCH] updated for version 7.4.085 Problem: When inserting text in Visual block mode and moving the cursor the wrong text gets repeated in other lines. Solution: Use the '[ mark to find the start of the actually inserted text. (Christian Brabandt) --- src/ops.c | 25 +++++++++++++++++++++++++ src/testdir/test39.in | 9 +++++++++ src/testdir/test39.ok | Bin 340 -> 377 bytes src/version.c | 2 ++ 4 files changed, 36 insertions(+) diff --git a/src/ops.c b/src/ops.c index 7571dc5c9..0aebfa14f 100644 --- a/src/ops.c +++ b/src/ops.c @@ -2640,6 +2640,31 @@ op_insert(oap, count1) { struct block_def bd2; + /* The user may have moved the cursor before inserting something, try + * to adjust the block for that. */ + if (oap->start.lnum == curbuf->b_op_start.lnum) + { + if (oap->op_type == OP_INSERT + && oap->start.col != curbuf->b_op_start.col) + { + oap->start.col = curbuf->b_op_start.col; + pre_textlen -= getviscol2(oap->start.col, oap->start.coladd) + - oap->start_vcol; + oap->start_vcol = getviscol2(oap->start.col, oap->start.coladd); + } + else if (oap->op_type == OP_APPEND + && oap->end.col >= curbuf->b_op_start.col) + { + oap->start.col = curbuf->b_op_start.col; + /* reset pre_textlen to the value of OP_INSERT */ + pre_textlen += bd.textlen; + pre_textlen -= getviscol2(oap->start.col, oap->start.coladd) + - oap->start_vcol; + oap->start_vcol = getviscol2(oap->start.col, oap->start.coladd); + oap->op_type = OP_INSERT; + } + } + /* * Spaces and tabs in the indent may have changed to other spaces and * tabs. Get the starting column again and correct the length. diff --git a/src/testdir/test39.in b/src/testdir/test39.in index 96995e089..77e2bd768 100644 --- a/src/testdir/test39.in +++ b/src/testdir/test39.in @@ -19,6 +19,10 @@ Gllllkkklllrq :" Test block-change G$khhhhhkkcmno :$-4,$w! test.out +:" Test block-insert using cursor keys for movement +/^aaaa/ +:exe ":norm! l\jjjlllI\\ \" +:/^aa/,/^$/w >> test.out :" gUe must uppercase a whole word, also when ß changes to SS Gothe youtußeuu endYpk0wgUe :" gUfx must uppercase until x, inclusive. @@ -40,6 +44,11 @@ G3o987652k02l2jr :qa! ENDTEST +aaaaaa +bbbbbb +cccccc +dddddd + abcdefghijklm abcdefghijklm abcdefghijklm diff --git a/src/testdir/test39.ok b/src/testdir/test39.ok index 4ebecf6cde60bfb4f90cf2960c4ffec2011efbda..4964d6a34b93691f1a8530296cb2a2994973317a 100644 GIT binary patch delta 46 wcmcb@^pj~qj!I%;qJjdD;7UqLQcwUAT*=AF3JO4iD