From 3f6978a3fefc16f203afbc64697fe04af329cf2b Mon Sep 17 00:00:00 2001 From: Zhongxing Xu Date: Thu, 11 Jun 2009 09:11:27 +0000 Subject: [PATCH] Bind the mistakenly generated nonloc::SymbolVal to struct correctly. See the comments for added test case for details. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@73189 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/RegionStore.cpp | 3 +++ test/Analysis/array-struct.c | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/lib/Analysis/RegionStore.cpp b/lib/Analysis/RegionStore.cpp index 528ee89a4c..000f06e5e5 100644 --- a/lib/Analysis/RegionStore.cpp +++ b/lib/Analysis/RegionStore.cpp @@ -1198,6 +1198,9 @@ RegionStoreManager::BindStruct(const GRState* St, const TypedRegion* R, SVal V){ if (V.isUnknown()) return KillStruct(St, R); + if (isa(V)) + return setDefaultValue(St, R, V); + nonloc::CompoundVal& CV = cast(V); nonloc::CompoundVal::iterator VI = CV.begin(), VE = CV.end(); RecordDecl::field_iterator FI = RD->field_begin(getContext()), diff --git a/test/Analysis/array-struct.c b/test/Analysis/array-struct.c index c0e1d8b7e3..0ad7ae7e82 100644 --- a/test/Analysis/array-struct.c +++ b/test/Analysis/array-struct.c @@ -148,3 +148,13 @@ void f15() { if (a[1]) // no-warning 1; } + +struct s3 p[1]; + +// Code from postgresql. +// Current cast logic of region store mistakenly leaves the final result region +// an ElementRegion of type 'char'. Then load a nonloc::SymbolVal from it and +// assigns to 'a'. +void f16(struct s3 *p) { + struct s3 a = *((struct s3*) ((char*) &p[0])); +} -- 2.50.1