From 3e2a9469ceb41261b796b51dc33329fd47c8c981 Mon Sep 17 00:00:00 2001 From: "William A. Rowe Jr" Date: Thu, 7 Jul 2005 23:47:05 +0000 Subject: [PATCH] The macro is simply not worth it; each of these various occurances differ as openssl has modified pointer constness from bump to bump. This needs testing on Netware, it builds clean on 0.9.6m, 0.9.7d, 0.9.7g, and 0.9.8-final on Win32. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@209675 13f79535-47bb-0310-9956-ffa450edef68 --- modules/ssl/ssl_engine_init.c | 14 ++++++++++++-- modules/ssl/ssl_scache_dbm.c | 7 ++++++- modules/ssl/ssl_scache_shmcb.c | 14 ++++++++++++-- modules/ssl/ssl_toolkit_compat.h | 7 ------- 4 files changed, 30 insertions(+), 12 deletions(-) diff --git a/modules/ssl/ssl_engine_init.c b/modules/ssl/ssl_engine_init.c index 7252d7cf4d..2b2cfd064c 100644 --- a/modules/ssl/ssl_engine_init.c +++ b/modules/ssl/ssl_engine_init.c @@ -719,7 +719,12 @@ static int ssl_server_import_cert(server_rec *s, { SSLModConfigRec *mc = myModConfig(s); ssl_asn1_t *asn1; - unsigned char *ptr; +#ifdef OPENSSL_VERSION_NUMBER +#if (OPENSSL_VERSION_NUMBER >= 0x00908000) + const /* ...shifting sands of openssl... */ +#endif +#endif + unsigned char *ptr; const char *type = ssl_asn1_keystr(idx); X509 *cert; @@ -757,7 +762,12 @@ static int ssl_server_import_key(server_rec *s, { SSLModConfigRec *mc = myModConfig(s); ssl_asn1_t *asn1; - unsigned char *ptr; +#ifdef OPENSSL_VERSION_NUMBER +#if (OPENSSL_VERSION_NUMBER >= 0x00908000) + const /* ...shifting sands of openssl... */ +#endif +#endif + unsigned char *ptr; const char *type = ssl_asn1_keystr(idx); int pkey_type = (idx == SSL_AIDX_RSA) ? EVP_PKEY_RSA : EVP_PKEY_DSA; EVP_PKEY *pkey; diff --git a/modules/ssl/ssl_scache_dbm.c b/modules/ssl/ssl_scache_dbm.c index 43cc0a6a4e..c54dad8197 100644 --- a/modules/ssl/ssl_scache_dbm.c +++ b/modules/ssl/ssl_scache_dbm.c @@ -196,7 +196,12 @@ SSL_SESSION *ssl_scache_dbm_retrieve(server_rec *s, UCHAR *id, int idlen) apr_datum_t dbmkey; apr_datum_t dbmval; SSL_SESSION *sess = NULL; - MODSSL_D2I_DATUM_TYPE ucpData; +#ifdef OPENSSL_VERSION_NUMBER +#if (OPENSSL_VERSION_NUMBER >= 0x0090707f) + const /* ...shifting sands of openssl... */ +#endif +#endif + unsigned char *ucpData; int nData; time_t expiry; time_t now; diff --git a/modules/ssl/ssl_scache_shmcb.c b/modules/ssl/ssl_scache_shmcb.c index d4b499a199..799ce728f9 100644 --- a/modules/ssl/ssl_scache_shmcb.c +++ b/modules/ssl/ssl_scache_shmcb.c @@ -1184,7 +1184,12 @@ static SSL_SESSION *shmcb_lookup_session_id( SHMCBHeader *header; SSL_SESSION *pSession = NULL; unsigned int curr_pos, loop, count; - MODSSL_D2I_DATUM_TYPE ptr; +#ifdef OPENSSL_VERSION_NUMBER +#if (OPENSSL_VERSION_NUMBER >= 0x0090707f) + const /* ...shifting sands of openssl... */ +#endif +#endif + unsigned char *ptr; time_t now; ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, @@ -1262,7 +1267,12 @@ static BOOL shmcb_remove_session_id( SHMCBIndex *idx; SHMCBHeader *header; unsigned int curr_pos, loop, count; - MODSSL_D2I_DATUM_TYPE ptr; +#ifdef OPENSSL_VERSION_NUMBER +#if (OPENSSL_VERSION_NUMBER >= 0x0090707f) + const /* ...shifting sands of openssl... */ +#endif +#endif + unsigned char *ptr; BOOL to_return = FALSE; ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, diff --git a/modules/ssl/ssl_toolkit_compat.h b/modules/ssl/ssl_toolkit_compat.h index 0b538e0faa..16e303662e 100644 --- a/modules/ssl/ssl_toolkit_compat.h +++ b/modules/ssl/ssl_toolkit_compat.h @@ -84,12 +84,6 @@ #endif #define MODSSL_CLIENT_CERT_CB_ARG_TYPE X509 #define MODSSL_PCHAR_CAST -#if (OPENSSL_VERSION_NUMBER < 0x0090707f) -# define MODSSL_D2I_DATUM_TYPE unsigned char * -#else -# define MODSSL_D2I_DATUM_TYPE const unsigned char * -#endif - #define modssl_X509_verify_cert X509_verify_cert @@ -152,7 +146,6 @@ typedef int (modssl_read_bio_cb_fn)(char*,int,int,void*); #define MODSSL_INFO_CB_ARG_TYPE SSL* #define MODSSL_CLIENT_CERT_CB_ARG_TYPE void #define MODSSL_PCHAR_CAST (char *) -#define MODSSL_D2I_DATUM_TYPE unsigned char * typedef int (modssl_read_bio_cb_fn)(char*,int,int); -- 2.40.0