From 3df1f98b4ab52f271dba5e13ec59cf4d1d093e1a Mon Sep 17 00:00:00 2001 From: Eric Haszlakiewicz Date: Sat, 23 Jun 2018 22:10:55 -0400 Subject: [PATCH] Explain why we're not setting the output name for static libraries when on Windows. --- CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index f64e371..f4f445a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -121,6 +121,9 @@ add_library(json-c-static set_property(TARGET json-c PROPERTY C_STANDARD 99) set_property(TARGET json-c-static PROPERTY C_STANDARD 99) if (NOT MSVC) +# Since MS Windows re-uses the .lib suffix for both static libraries +# and the "import library" that's needed to actually link against a +# dll, we can't use the same name for static and dynamic libs. :( set_target_properties(json-c-static PROPERTIES OUTPUT_NAME json-c) endif() -- 2.40.0