From 3ce3dea60646d8a5a1c952469a2eb65f937875b3 Mon Sep 17 00:00:00 2001 From: Recursing Date: Sun, 23 Dec 2018 04:48:14 +0100 Subject: [PATCH] Use generator instead of list in code examples (GH-11203) There is no need to create a list for `sum` Also, becomes consistent with the first example in Doc/library/os.rst --- Lib/os.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/os.py b/Lib/os.py index 4b31e4dcc8..7741c7580d 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -327,7 +327,7 @@ def walk(top, topdown=True, onerror=None, followlinks=False): from os.path import join, getsize for root, dirs, files in os.walk('python/Lib/email'): print(root, "consumes", end="") - print(sum([getsize(join(root, name)) for name in files]), end="") + print(sum(getsize(join(root, name)) for name in files), end="") print("bytes in", len(files), "non-directory files") if 'CVS' in dirs: dirs.remove('CVS') # don't visit CVS directories @@ -446,7 +446,7 @@ if {open, stat} <= supports_dir_fd and {scandir, stat} <= supports_fd: import os for root, dirs, files, rootfd in os.fwalk('python/Lib/email'): print(root, "consumes", end="") - print(sum([os.stat(name, dir_fd=rootfd).st_size for name in files]), + print(sum(os.stat(name, dir_fd=rootfd).st_size for name in files), end="") print("bytes in", len(files), "non-directory files") if 'CVS' in dirs: -- 2.49.0