From 3c9e4cdbf2ec876dbb71aa80a4cc18662fbd41c2 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 5 Jan 2015 12:22:50 +0100 Subject: [PATCH] Fix oversight in recent pg_basebackup fix causing pg_receivexlog failures. A oversight in 2c0a485896 causes 'could not create archive status file "...": No such file or directory' errors in pg_receivexlog if the target directory doesn't happen to contain a archive_status directory. That's due to a stupidly left over 'true' constant instead of mark_done being passed down to ProcessXLogDataMsg(). The bug is only present in the master branch, and luckily wasn't released. Spotted by Fujii Masao. --- src/bin/pg_basebackup/receivelog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c index dc1d7d8648..30c4b10652 100644 --- a/src/bin/pg_basebackup/receivelog.c +++ b/src/bin/pg_basebackup/receivelog.c @@ -906,7 +906,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline, { if (!ProcessXLogDataMsg(conn, copybuf, r, &blockpos, timeline, basedir, stream_stop, - partial_suffix, true)) + partial_suffix, mark_done)) goto error; /* -- 2.40.0