From 3af51fe19626b039704a57b773775665e1a8f0ae Mon Sep 17 00:00:00 2001 From: Yoshito Umaoka Date: Sat, 5 Mar 2016 01:31:16 +0000 Subject: [PATCH] ICU-12186 Fixed Eclipse compiler warnings - mostly javadoc warnings. X-SVN-Rev: 38496 --- .../src/com/ibm/icu/impl/locale/LocaleValidityChecker.java | 1 + .../classes/core/src/com/ibm/icu/text/UnicodeFilter.java | 1 + icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java | 2 ++ icu4j/main/classes/core/src/com/ibm/icu/util/TimeZone.java | 1 + icu4j/main/classes/core/src/com/ibm/icu/util/ULocale.java | 1 + .../core/src/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java | 7 ++++--- .../src/com/ibm/icu/dev/test/util/TestUtilities.java | 2 +- 7 files changed, 11 insertions(+), 4 deletions(-) diff --git a/icu4j/main/classes/core/src/com/ibm/icu/impl/locale/LocaleValidityChecker.java b/icu4j/main/classes/core/src/com/ibm/icu/impl/locale/LocaleValidityChecker.java index 783d5a0b72b..2d5f2ec60fb 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/impl/locale/LocaleValidityChecker.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/impl/locale/LocaleValidityChecker.java @@ -61,6 +61,7 @@ public class LocaleValidityChecker { static Pattern SEPARATOR = Pattern.compile("[-_]"); + @SuppressWarnings("unused") private static final Pattern VALID_X = Pattern.compile("[a-zA-Z0-9]{2,8}(-[a-zA-Z0-9]{2,8})*"); public boolean isValid(ULocale locale, Where where) { diff --git a/icu4j/main/classes/core/src/com/ibm/icu/text/UnicodeFilter.java b/icu4j/main/classes/core/src/com/ibm/icu/text/UnicodeFilter.java index 55ec2ed6877..a7e71a679ac 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/text/UnicodeFilter.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/text/UnicodeFilter.java @@ -15,6 +15,7 @@ package com.ibm.icu.text; * transformation. * @stable ICU 2.0 */ +@SuppressWarnings("javadoc") // com.imb.icu.text.Transliterator is in another project public abstract class UnicodeFilter implements UnicodeMatcher { /** diff --git a/icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java b/icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java index 52e05d63f13..33aeb40ce8f 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java @@ -605,6 +605,7 @@ public class Currency extends MeasureUnit { * @see #getName(Locale, int, boolean[]) * @stable ICU 49 */ + @SuppressWarnings("javadoc") // java.util.Currency#getDisplayName() is introduced in Java 7 public String getDisplayName() { return getName(Locale.getDefault(), LONG_NAME, null); } @@ -624,6 +625,7 @@ public class Currency extends MeasureUnit { * @see #getName(Locale, int, boolean[]) * @stable ICU 49 */ + @SuppressWarnings("javadoc") // java.util.Currency#getDisplayName() is introduced in Java 7 public String getDisplayName(Locale locale) { return getName(locale, LONG_NAME, null); } diff --git a/icu4j/main/classes/core/src/com/ibm/icu/util/TimeZone.java b/icu4j/main/classes/core/src/com/ibm/icu/util/TimeZone.java index 8078106096f..53b0e88ff0e 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/util/TimeZone.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/util/TimeZone.java @@ -673,6 +673,7 @@ abstract public class TimeZone implements Serializable, Cloneable, Freezable { // using serialver from jdk1.4.2_05 private static final long serialVersionUID = 3715177670352309217L; diff --git a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java index d217399fd20..95822d509e8 100644 --- a/icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java +++ b/icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestMonkey.java @@ -158,7 +158,7 @@ public class RBBITestMonkey extends TestFmwk { } int next(int prevPos) { - int p0, p1, p2, p3; // Indices of the significant code points around the + int /*p0,*/ p1, p2, p3; // Indices of the significant code points around the // break position being tested. The candidate break // location is before p2. @@ -170,14 +170,14 @@ public class RBBITestMonkey extends TestFmwk { if (prevPos >= fText.length()) { return -1; } - p0 = p1 = p2 = p3 = prevPos; + /* p0 = */ p1 = p2 = p3 = prevPos; c3 = UTF16.charAt(fText, prevPos); c0 = c1 = c2 = 0; // Loop runs once per "significant" character position in the input text. for (;;) { // Move all of the positions forward in the input string. - p0 = p1; c0 = c1; + /* p0 = p1;*/ c0 = c1; p1 = p2; c1 = c2; p2 = p3; c2 = c3; @@ -708,6 +708,7 @@ public class RBBITestMonkey extends TestFmwk { // Remove dictionary characters. // The monkey test reference implementation of line break does not replicate the dictionary behavior, // so dictionary characters are omitted from the monkey test data. + @SuppressWarnings("unused") UnicodeSet dictionarySet = new UnicodeSet( "[[:LineBreak = Complex_Context:] & [[:Script = Thai:][:Script = Lao:][:Script = Khmer:] [:script = Myanmar:]]]"); diff --git a/icu4j/main/tests/translit/src/com/ibm/icu/dev/test/util/TestUtilities.java b/icu4j/main/tests/translit/src/com/ibm/icu/dev/test/util/TestUtilities.java index 11c7d83bafe..783a4cc58cd 100644 --- a/icu4j/main/tests/translit/src/com/ibm/icu/dev/test/util/TestUtilities.java +++ b/icu4j/main/tests/translit/src/com/ibm/icu/dev/test/util/TestUtilities.java @@ -329,7 +329,7 @@ public class TestUtilities extends TestFmwk { logln("Comparing next"); mi.reset(); localMap = new TreeMap(); - String lastValue = null; +// String lastValue = null; while (mi.next()) { // if (!UnicodeMap.areEqual(lastValue, mi.value)) { // // System.out.println("Change: " + Utility.hex(mi.codepoint) + " => " + mi.value); -- 2.40.0