From 3a7c7162490b4d5d9e33e11a730f26df182e1265 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Wed, 1 Apr 2020 14:49:52 +0200 Subject: [PATCH] Remove unnecessary check in runtime_compile_time_binary_operands.phpt Now that operator errors are detected more accurately, we no longer have any cases where we throw a compile-time error instead of a run-time exception, so we can drop this check now. --- Zend/tests/runtime_compile_time_binary_operands.phpt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Zend/tests/runtime_compile_time_binary_operands.phpt b/Zend/tests/runtime_compile_time_binary_operands.phpt index 8c15a9658f..9fe76b2efb 100644 --- a/Zend/tests/runtime_compile_time_binary_operands.phpt +++ b/Zend/tests/runtime_compile_time_binary_operands.phpt @@ -113,9 +113,6 @@ function prepareLine($op1, $op2, $cmp, $operator) { $result = makeParam($cmp()); $line .= "if (" . ($result === "(NAN)" ? "!is_nan($compare)" : "$compare !== $result") . ") { $error }"; } catch (Error $e) { - if (get_class($e) == "Error") { - return "// exempt $op1_p $operator $op2_p from checking, it generates a compile time error"; - } $msg = makeParam($e->getMessage()); $line .= "try { $compare; $error } catch (Error \$e) { if (\$e->getMessage() !== $msg) { $error } }"; } -- 2.40.0