From 3a57782587a8ccd38e042689c87e5ed8d161503c Mon Sep 17 00:00:00 2001 From: Greg Ames Date: Fri, 20 Jul 2007 16:20:10 +0000 Subject: [PATCH] the cost of synchronized SMP proof updates far outweighs the value of having 100% accurate MaxRequestsPerChild. * it doesn't even count requests, it counts connections. * all it is is a number someone pulls out of a hat in an attempt to deal with resource leaks. i.e., no strong need for accuracy. atomic operations are relatively expensive and this is mainline code. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@558039 13f79535-47bb-0310-9956-ffa450edef68 --- server/mpm/worker/worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/mpm/worker/worker.c b/server/mpm/worker/worker.c index 5b531c6ede..dbf021541d 100644 --- a/server/mpm/worker/worker.c +++ b/server/mpm/worker/worker.c @@ -892,7 +892,7 @@ worker_pop: bucket_alloc = apr_bucket_alloc_create(ptrans); process_socket(ptrans, csd, process_slot, thread_slot, bucket_alloc); worker_sockets[thread_slot] = NULL; - requests_this_child--; /* FIXME: should be synchronized - aaron */ + requests_this_child--; apr_pool_clear(ptrans); last_ptrans = ptrans; } -- 2.50.1