From 3a0b7d29770107658ba13e365a8550cd3dc0e40e Mon Sep 17 00:00:00 2001 From: sr55 Date: Mon, 26 Jun 2017 20:41:20 +0100 Subject: [PATCH] WinGui: AutoName Sort the InvalidFileNameChars Array before doing a Binary Search on it. --- win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs index c62161264..5d936be0c 100644 --- a/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs +++ b/win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs @@ -1542,10 +1542,11 @@ namespace HandBrakeWPF.ViewModels /// True if valid private bool IsValidAutonameFormat(string input, bool isSilent) { + char[] invalidchars = Path.GetInvalidFileNameChars(); + Array.Sort(invalidchars); foreach (var characterToTest in input) { - // we binary search for the character in the invalid set. This should be lightning fast. - if (Array.BinarySearch(Path.GetInvalidFileNameChars(), characterToTest) >= 0) + if (Array.BinarySearch(invalidchars, characterToTest) >= 0) { if (!isSilent) { -- 2.40.0