From 392d9034ae1408b4a8e52a440c76a330dec666f3 Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Mon, 18 Feb 2008 18:02:15 +0000 Subject: [PATCH] Fix Vorbis detection for Ogg files with ID3 tags. --- magic/Magdir/vorbis | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/magic/Magdir/vorbis b/magic/Magdir/vorbis index b2fc4edd..b873f798 100644 --- a/magic/Magdir/vorbis +++ b/magic/Magdir/vorbis @@ -11,8 +11,15 @@ # probable things advanced users would want to uncomment are probably # the number of comments and the encoder version. # +# FIXME: The first match has been made a search, so that it can skip +# over prepended ID3 tags. This will work for MIME type detection, but +# won't work for detecting other properties of the file (they all need +# to be made relative to the search). In any case, if the file has ID3 +# tags, the ID3 information will be printed, not the Ogg information, +# so until that's fixed, this doesn't matter. +# # --- Ogg Framing --- -0 string OggS Ogg data +0 search/1000 OggS Ogg data !:mime application/ogg >4 byte !0 UNKNOWN REVISION %u ##>4 byte 0 revision 0 -- 2.40.0