From 38278e6ec75ff51d9e69136b0d5ad34d96c24bee Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 1 May 2019 19:34:00 +0000 Subject: [PATCH] Make check-clang depend on the clang-check binary always check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-tidy, clang-refactor, etc) if the static analyzer is enabled. However, several lit tests call clang-check unconditionally, so always depend on it. Fixes a "could not find clang-check" lit warning in clean builds with the static analyzer disabled. Also sort the deps in the CMake file and put just one dep on each line. Differential Revision: https://reviews.llvm.org/D61324 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359717 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/gn/secondary/clang/test/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/gn/secondary/clang/test/BUILD.gn b/utils/gn/secondary/clang/test/BUILD.gn index b5c5ec058b9..b7fd034fde1 100644 --- a/utils/gn/secondary/clang/test/BUILD.gn +++ b/utils/gn/secondary/clang/test/BUILD.gn @@ -108,6 +108,7 @@ group("test") { ":lit_unit_site_cfg", "//clang/lib/Headers", "//clang/tools/c-index-test", + "//clang/tools/clang-check", "//clang/tools/clang-diff", "//clang/tools/clang-format", "//clang/tools/clang-import-test", @@ -147,7 +148,6 @@ group("test") { } if (clang_enable_static_analyzer) { deps += [ - "//clang/tools/clang-check", "//clang/tools/clang-extdef-mapping", ] } -- 2.40.0