From 37e0b38220ae42c2f0aba086d2252b7cbebcd434 Mon Sep 17 00:00:00 2001
From: cristy <urban-warrior@git.imagemagick.org>
Date: Tue, 7 Jun 2011 13:31:21 +0000
Subject: [PATCH]

---
 coders/fpx.c       |  6 +++---
 coders/jpeg.c      |  2 +-
 coders/msl.c       |  2 +-
 coders/tga.c       |  2 +-
 magick/blob.c      |  2 +-
 magick/geometry.c  |  4 ++--
 magick/identify.c  |  2 +-
 magick/nt-base.c   |  6 +++---
 magick/property.c  |  8 ++++----
 magick/string.c    |  8 ++++----
 magick/threshold.c |  2 +-
 magick/utility.c   |  2 +-
 magick/widget.c    | 10 +++++-----
 wand/mogrify.c     |  2 +-
 14 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/coders/fpx.c b/coders/fpx.c
index 7d7c14a63..f7e863c1c 100644
--- a/coders/fpx.c
+++ b/coders/fpx.c
@@ -302,7 +302,7 @@ static Image *ReadFPXImage(const ImageInfo *image_info,ExceptionInfo *exception)
           Note image label.
         */
         label=(char *) NULL;
-        if (~summary_info.title.length >= MaxTextExtent)
+        if (~summary_info.title.length >= (MaxTextExtent-1))
           label=(char *) AcquireQuantumMemory(summary_info.title.length+
             MaxTextExtent,sizeof(*label));
         if (label == (char *) NULL)
@@ -326,7 +326,7 @@ static Image *ReadFPXImage(const ImageInfo *image_info,ExceptionInfo *exception)
           Note image comment.
         */
         comments=(char *) NULL;
-        if (~summary_info.comments.length >= MaxTextExtent)
+        if (~summary_info.comments.length >= (MaxTextExtent-1))
           comments=(char *) AcquireQuantumMemory(summary_info.comments.length+
             MaxTextExtent,sizeof(*comments));
         if (comments == (char *) NULL)
@@ -935,7 +935,7 @@ static MagickBooleanType WriteFPXImage(const ImageInfo *image_info,Image *image)
       summary_info.title_valid=MagickTrue;
       length=strlen(label);
       summary_info.title.length=length;
-      if (~length >= MaxTextExtent)
+      if (~length >= (MaxTextExtent-1))
         summary_info.title.ptr=(unsigned char *) AcquireQuantumMemory(
           length+MaxTextExtent,sizeof(*summary_info.title.ptr));
       if (summary_info.title.ptr == (unsigned char *) NULL)
diff --git a/coders/jpeg.c b/coders/jpeg.c
index 99eb41174..1996e6c00 100644
--- a/coders/jpeg.c
+++ b/coders/jpeg.c
@@ -369,7 +369,7 @@ static boolean ReadComment(j_decompress_ptr jpeg_info)
   if (length <= 0)
     return(MagickTrue);
   comment=(char *) NULL;
-  if (~length >= MaxTextExtent)
+  if (~length >= (MaxTextExtent-1))
     comment=(char *) AcquireQuantumMemory(length+MaxTextExtent,
       sizeof(*comment));
   if (comment == (char *) NULL)
diff --git a/coders/msl.c b/coders/msl.c
index 74bab38c2..d4dca0d93 100644
--- a/coders/msl.c
+++ b/coders/msl.c
@@ -7345,7 +7345,7 @@ static void MSLCharacters(void *context,const xmlChar *c,int length)
   else
     {
       msl_info->content=(char *) NULL;
-      if (~length >= MaxTextExtent)
+      if (~length >= (MaxTextExtent-1))
         msl_info->content=(char *) AcquireQuantumMemory(length+MaxTextExtent,
           sizeof(*msl_info->content));
       if (msl_info->content != (char *) NULL)
diff --git a/coders/tga.c b/coders/tga.c
index 87f954b42..f963b88a4 100644
--- a/coders/tga.c
+++ b/coders/tga.c
@@ -271,7 +271,7 @@ static Image *ReadTGAImage(const ImageInfo *image_info,ExceptionInfo *exception)
       */
       length=(size_t) tga_info.id_length;
       comment=(char *) NULL;
-      if (~length >= MaxTextExtent)
+      if (~length >= (MaxTextExtent-1))
         comment=(char *) AcquireQuantumMemory(length+MaxTextExtent,
           sizeof(*comment));
       if (comment == (char *) NULL)
diff --git a/magick/blob.c b/magick/blob.c
index 0e30d90b3..98cd9fe77 100644
--- a/magick/blob.c
+++ b/magick/blob.c
@@ -983,7 +983,7 @@ MagickExport unsigned char *FileToBlob(const char *filename,const size_t extent,
     }
   *length=(size_t) MagickMin((MagickSizeType) offset,extent);
   blob=(unsigned char *) NULL;
-  if (~(*length) >= MaxTextExtent)
+  if (~(*length) >= (MaxTextExtent-1))
     blob=(unsigned char *) AcquireQuantumMemory(*length+MaxTextExtent,
       sizeof(*blob));
   if (blob == (unsigned char *) NULL)
diff --git a/magick/geometry.c b/magick/geometry.c
index 53db9e569..a705b3554 100644
--- a/magick/geometry.c
+++ b/magick/geometry.c
@@ -102,7 +102,7 @@ MagickExport MagickStatusType GetGeometry(const char *geometry,ssize_t *x,
   flags=NoValue;
   if ((geometry == (char *) NULL) || (*geometry == '\0'))
     return(flags);
-  if (strlen(geometry) >= MaxTextExtent)
+  if (strlen(geometry) >= (MaxTextExtent-1))
     return(flags);
   (void) CopyMagickString(pedantic_geometry,geometry,MaxTextExtent);
   for (p=pedantic_geometry; *p != '\0'; )
@@ -757,7 +757,7 @@ MagickExport MagickStatusType ParseGeometry(const char *geometry,
   flags=NoValue;
   if ((geometry == (char *) NULL) || (*geometry == '\0'))
     return(flags);
-  if (strlen(geometry) >= MaxTextExtent)
+  if (strlen(geometry) >= (MaxTextExtent-1))
     return(flags);
   (void) CopyMagickString(pedantic_geometry,geometry,MaxTextExtent);
   for (p=pedantic_geometry; *p != '\0'; )
diff --git a/magick/identify.c b/magick/identify.c
index 4ecebf177..85d7f3d60 100644
--- a/magick/identify.c
+++ b/magick/identify.c
@@ -1005,7 +1005,7 @@ MagickExport MagickBooleanType IdentifyImage(Image *image,FILE *file,
               length=(size_t) (GetStringInfoDatum(profile)[i++] << 8);
               length|=GetStringInfoDatum(profile)[i++];
               attribute=(char *) NULL;
-              if (~length >= MaxTextExtent)
+              if (~length >= (MaxTextExtent-1))
                 attribute=(char *) AcquireQuantumMemory(length+
                   MaxTextExtent,sizeof(*attribute));
               if (attribute != (char *) NULL)
diff --git a/magick/nt-base.c b/magick/nt-base.c
index 14dc3b586..b9b89a695 100644
--- a/magick/nt-base.c
+++ b/magick/nt-base.c
@@ -1374,11 +1374,11 @@ MagickExport DIR *NTOpenDirectory(const char *path)
 
   assert(path != (const char *) NULL);
   length=CopyMagickString(file_specification,path,MaxTextExtent);
-  if (length >= MaxTextExtent)
+  if (length >= (MaxTextExtent-1))
     return((DIR *) NULL);
   length=ConcatenateMagickString(file_specification,DirectorySeparator,
     MaxTextExtent);
-  if (length >= MaxTextExtent)
+  if (length >= (MaxTextExtent-1))
     return((DIR *) NULL);
   entry=(DIR *) AcquireMagickMemory(sizeof(DIR));
   if (entry != (DIR *) NULL)
@@ -1389,7 +1389,7 @@ MagickExport DIR *NTOpenDirectory(const char *path)
   if (entry->hSearch == INVALID_HANDLE_VALUE)
     {
       length=ConcatenateMagickString(file_specification,"\\*.*",MaxTextExtent);
-      if (length >= MaxTextExtent)
+      if (length >= (MaxTextExtent-1))
         {
           entry=(DIR *) RelinquishMagickMemory(entry);
           return((DIR *) NULL);
diff --git a/magick/property.c b/magick/property.c
index 86a266819..60acd7641 100644
--- a/magick/property.c
+++ b/magick/property.c
@@ -588,7 +588,7 @@ static MagickBooleanType Get8BIMProperty(const Image *image,const char *key)
     if ((count != 0) && ((size_t) count <= length))
       {
         resource=(char *) NULL;
-        if (~(1UL*count) >= MaxTextExtent)
+        if (~(1UL*count) >= (MaxTextExtent-1))
           resource=(char *) AcquireQuantumMemory((size_t) count+MaxTextExtent,
             sizeof(*resource));
         if (resource != (char *) NULL)
@@ -625,7 +625,7 @@ static MagickBooleanType Get8BIMProperty(const Image *image,const char *key)
       We have the resource of interest.
     */
     attribute=(char *) NULL;
-    if (~(1UL*count) >= MaxTextExtent)
+    if (~(1UL*count) >= (MaxTextExtent-1))
       attribute=(char *) AcquireQuantumMemory((size_t) count+MaxTextExtent,
         sizeof(*attribute));
     if (attribute != (char *) NULL)
@@ -732,7 +732,7 @@ static MagickBooleanType GetEXIFProperty(const Image *image,
    { \
      length+=FormatLocaleString(buffer+length,MaxTextExtent-length, \
        format", ",arg); \
-     if (length >= MaxTextExtent - 1) \
+     if (length >= (MaxTextExtent-1)) \
        length=MaxTextExtent-1; \
      p1+=size; \
    } \
@@ -758,7 +758,7 @@ static MagickBooleanType GetEXIFProperty(const Image *image,
    { \
      length+=FormatLocaleString(buffer+length,MaxTextExtent-length, \
        format", ",arg1, arg2); \
-     if (length >= MaxTextExtent - 1) \
+     if (length >= (MaxTextExtent-1)) \
        length=MaxTextExtent-1; \
      p1+=size; \
    } \
diff --git a/magick/string.c b/magick/string.c
index 6ae43debe..59f6c3e53 100644
--- a/magick/string.c
+++ b/magick/string.c
@@ -168,7 +168,7 @@ MagickExport StringInfo *AcquireStringInfo(const size_t length)
   if (string_info->length != 0)
     {
       string_info->datum=(unsigned char *) NULL;
-      if (~string_info->length >= MaxTextExtent)
+      if (~string_info->length >= (MaxTextExtent-1))
         string_info->datum=(unsigned char *) AcquireQuantumMemory(
           string_info->length+MaxTextExtent,sizeof(*string_info->datum));
       if (string_info->datum == (unsigned char *) NULL)
@@ -551,7 +551,7 @@ MagickExport StringInfo *ConfigureFileToStringInfo(const char *filename)
     }
   length=(size_t) offset;
   string=(char *) NULL;
-  if (~length > MaxTextExtent)
+  if (~length >= (MaxTextExtent-1))
     string=(char *) AcquireQuantumMemory(length+MaxTextExtent,sizeof(*string));
   if (string == (char *) NULL)
     {
@@ -873,7 +873,7 @@ MagickExport char *EscapeString(const char *source,const char escape)
         length++;
       }
   destination=(char *) NULL;
-  if (~length >= MaxTextExtent)
+  if (~length >= (MaxTextExtent-1))
     destination=(char *) AcquireQuantumMemory(length+MaxTextExtent,
       sizeof(*destination));
   if (destination == (char *) NULL)
@@ -1795,7 +1795,7 @@ MagickExport char *StringInfoToString(const StringInfo *string_info)
 
   string=(char *) NULL;
   length=string_info->length;
-  if (~length >= MaxTextExtent)
+  if (~length >= (MaxTextExtent-1))
     string=(char *) AcquireQuantumMemory(length+MaxTextExtent,sizeof(*string));
   if (string == (char *) NULL)
     return((char *) NULL);
diff --git a/magick/threshold.c b/magick/threshold.c
index dd4a1457b..532ed1d6b 100644
--- a/magick/threshold.c
+++ b/magick/threshold.c
@@ -1413,7 +1413,7 @@ MagickExport MagickBooleanType OrderedPosterizeImageChannel(Image *image,
     threshold_map=p;
     while (((isspace((int) ((unsigned char) *p)) == 0) && (*p != ',')) &&
                     (*p != '\0')) {
-      if ((p-threshold_map) >= MaxTextExtent)
+      if ((p-threshold_map) >= (MaxTextExtent-1))
         break;
       token[p-threshold_map] = *p;
       p++;
diff --git a/magick/utility.c b/magick/utility.c
index c1007465b..6d3cbb1fc 100644
--- a/magick/utility.c
+++ b/magick/utility.c
@@ -877,7 +877,7 @@ MagickExport MagickBooleanType ExpandFilenames(int *number_arguments,
               (void) ConcatenateMagickString(path,subimage,MaxTextExtent);
               (void) ConcatenateMagickString(path,"]",MaxTextExtent);
             }
-          if (strlen(path) >= MaxTextExtent)
+          if (strlen(path) >= (MaxTextExtent-1))
             ThrowFatalException(OptionFatalError,"FilenameTruncated");
           if (destroy != MagickFalse)
             {
diff --git a/magick/widget.c b/magick/widget.c
index 8b647aca9..07742fe29 100644
--- a/magick/widget.c
+++ b/magick/widget.c
@@ -2699,7 +2699,7 @@ MagickExport void XColorBrowserWidget(Display *display,XWindows *windows,
         if ((status != Success) || (type != XA_STRING) || (format == 32) ||
             (length == 0))
           break;
-        if ((Extent(reply_info.text)+length) >= MaxTextExtent)
+        if ((Extent(reply_info.text)+length) >= (MaxTextExtent-1))
           (void) XBell(display,0);
         else
           {
@@ -4124,7 +4124,7 @@ MagickExport int XDialogWidget(Display *display,XWindows *windows,
         if ((status != Success) || (type != XA_STRING) || (format == 32) ||
             (length == 0))
           break;
-        if ((Extent(reply_info.text)+length) >= MaxTextExtent)
+        if ((Extent(reply_info.text)+length) >= (MaxTextExtent-1))
           (void) XBell(display,0);
         else
           {
@@ -5344,7 +5344,7 @@ MagickExport void XFileBrowserWidget(Display *display,XWindows *windows,
         if ((status != Success) || (type != XA_STRING) || (format == 32) ||
             (length == 0))
           break;
-        if ((Extent(reply_info.text)+length) >= MaxTextExtent)
+        if ((Extent(reply_info.text)+length) >= (MaxTextExtent-1))
           (void) XBell(display,0);
         else
           {
@@ -6562,7 +6562,7 @@ MagickExport void XFontBrowserWidget(Display *display,XWindows *windows,
         if ((status != Success) || (type != XA_STRING) || (format == 32) ||
             (length == 0))
           break;
-        if ((Extent(reply_info.text)+length) >= MaxTextExtent)
+        if ((Extent(reply_info.text)+length) >= (MaxTextExtent-1))
           (void) XBell(display,0);
         else
           {
@@ -7569,7 +7569,7 @@ MagickExport void XListBrowserWidget(Display *display,XWindows *windows,
         if ((status != Success) || (type != XA_STRING) || (format == 32) ||
             (length == 0))
           break;
-        if ((Extent(reply_info.text)+length) >= MaxTextExtent)
+        if ((Extent(reply_info.text)+length) >= (MaxTextExtent-1))
           (void) XBell(display,0);
         else
           {
diff --git a/wand/mogrify.c b/wand/mogrify.c
index 80bf1bfcf..815bac67b 100644
--- a/wand/mogrify.c
+++ b/wand/mogrify.c
@@ -8050,7 +8050,7 @@ This has been merged completely into MogrifyImage()
                 */
                 length=strlen(argv[i+1]);
                 token=(char *) NULL;
-                if (~length >= MaxTextExtent)
+                if (~length >= (MaxTextExtent-1))
                   token=(char *) AcquireQuantumMemory(length+MaxTextExtent,
                     sizeof(*token));
                 if (token == (char *) NULL)
-- 
2.40.0