From 366f4a96248dc85a37b17c78ce41d2a531377ba0 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Mon, 1 Aug 2016 17:36:14 +0900 Subject: [PATCH] Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com --- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml index 11b7c37c25..34d2f0bb6c 100644 --- a/doc/src/sgml/ref/pg_basebackup.sgml +++ b/doc/src/sgml/ref/pg_basebackup.sgml @@ -185,7 +185,7 @@ PostgreSQL documentation Enables gzip compression of tar file output, and specifies the - compression level (1 through 9, 9 being best + compression level (0 through 9, 0 being no compression and 9 being best compression). Compression is only available when using the tar format. diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 817977a070..c78b7ec885 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -1059,7 +1059,7 @@ main(int argc, char **argv) break; case 'Z': compresslevel = atoi(optarg); - if (compresslevel <= 0 || compresslevel > 9) + if (compresslevel < 0 || compresslevel > 9) { fprintf(stderr, _("%s: invalid compression level \"%s\"\n"), progname, optarg); -- 2.40.0