From 358473c1a2a692a496bbbeca330c1e4d52fc78b0 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Mon, 16 Feb 1998 14:52:42 +0000 Subject: [PATCH] Andrew Kuchling writes: First, the RNG in whrandom.py sucks if you let it seed itself from the time. The problem is the line: t = int((t&0xffffff) | (t>>24)) Since it ORs the two parts together, the resulting value has mostly ON bits. Change | to ^, and you don't lose any randomness. --- Lib/whrandom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/whrandom.py b/Lib/whrandom.py index bd2dcf7bef..95e88f3399 100644 --- a/Lib/whrandom.py +++ b/Lib/whrandom.py @@ -50,7 +50,7 @@ class whrandom: # Initialize from current time import time t = long(time.time() * 256) - t = int((t&0xffffff) | (t>>24)) + t = int((t&0xffffff) ^ (t>>24)) t, x = divmod(t, 256) t, y = divmod(t, 256) t, z = divmod(t, 256) -- 2.40.0