From 354e1e0ff463dd6f5cddf932dfd593d96cfc7bd3 Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Mon, 3 Aug 2009 13:16:24 +0000 Subject: [PATCH] - Re-fix stream_is_local() memory leaks --- ext/standard/streamsfuncs.c | 13 +++++++++++-- ext/standard/tests/streams/stream_is_local.phpt | 17 +++++++++++++++++ 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 ext/standard/tests/streams/stream_is_local.phpt diff --git a/ext/standard/streamsfuncs.c b/ext/standard/streamsfuncs.c index 4f8e561ead..cc85c04431 100644 --- a/ext/standard/streamsfuncs.c +++ b/ext/standard/streamsfuncs.c @@ -1750,8 +1750,17 @@ PHP_FUNCTION(stream_is_local) } wrapper = stream->wrapper; } else { - convert_to_string_ex(&zstream); - wrapper = php_stream_locate_url_wrapper(Z_STRVAL_P(zstream), NULL, 0 TSRMLS_CC); + zval *copy_tmp; + + ALLOC_ZVAL(copy_tmp); + *copy_tmp = *zstream; + zval_copy_ctor(copy_tmp); + INIT_PZVAL(copy_tmp); + convert_to_string(copy_tmp); + + wrapper = php_stream_locate_url_wrapper(Z_STRVAL_P(copy_tmp), NULL, 0 TSRMLS_CC); + + zval_ptr_dtor(©_tmp); } if(!wrapper) { diff --git a/ext/standard/tests/streams/stream_is_local.phpt b/ext/standard/tests/streams/stream_is_local.phpt new file mode 100644 index 0000000000..c90eb19cde --- /dev/null +++ b/ext/standard/tests/streams/stream_is_local.phpt @@ -0,0 +1,17 @@ +--TEST-- +Testing stream_is_local() +--FILE-- + +--EXPECT-- +bool(true) +int(1) +bool(true) -- 2.50.1