From 354797ccade3c7fa463c415e3d90fad907e4be5d Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Mon, 3 Dec 2001 19:45:06 +0000 Subject: [PATCH] Fix the final two issues in Armin Rigo's SF bug #488477: apply_slice() and assign_slice() weren't properly DECREF'ing the temporary slice object they created. (Shame on me. :-) --- Python/ceval.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Python/ceval.c b/Python/ceval.c index b41ef5a71e..535851775f 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -3398,8 +3398,11 @@ apply_slice(PyObject *u, PyObject *v, PyObject *w) /* return u[v:w] */ } else { PyObject *slice = PySlice_New(v, w, NULL); - if (slice != NULL) - return PyObject_GetItem(u, slice); + if (slice != NULL) { + PyObject *res = PyObject_GetItem(u, slice); + Py_DECREF(slice); + return res; + } else return NULL; } @@ -3426,10 +3429,13 @@ assign_slice(PyObject *u, PyObject *v, PyObject *w, PyObject *x) else { PyObject *slice = PySlice_New(v, w, NULL); if (slice != NULL) { + int res; if (x != NULL) - return PyObject_SetItem(u, slice, x); + res = PyObject_SetItem(u, slice, x); else - return PyObject_DelItem(u, slice); + res = PyObject_DelItem(u, slice); + Py_DECREF(slice); + return res; } else return -1; -- 2.50.1