From 3539cdb98b1132d30795f932920ff1c90f94b4e8 Mon Sep 17 00:00:00 2001 From: Steve Naroff Date: Tue, 2 Dec 2008 17:54:50 +0000 Subject: [PATCH] Add a couple FIXME's. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@60427 91177308-0d34-0410-b5e6-96231b3b80d8 --- Driver/RewriteObjC.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Driver/RewriteObjC.cpp b/Driver/RewriteObjC.cpp index aa898a8fe6..06a4a5caed 100644 --- a/Driver/RewriteObjC.cpp +++ b/Driver/RewriteObjC.cpp @@ -624,6 +624,9 @@ void RewriteObjC::RewritePropertyImplDecl(ObjCPropertyImplDecl *PID, RewriteObjCMethodDecl(PD->getGetterMethodDecl(), Getr); Getr += "{ "; // Synthesize an explicit cast to gain access to the ivar. + // FIXME: deal with code generation implications for various property + // attributes (copy, retain, nonatomic). + // See objc-act.c:objc_synthesize_new_getter() for details. Getr += "return " + getIvarAccessString(ClassDecl, OID); Getr += "; }"; InsertText(onePastSemiLoc, Getr.c_str(), Getr.size()); @@ -645,6 +648,9 @@ void RewriteObjC::RewritePropertyImplDecl(ObjCPropertyImplDecl *PID, RewriteObjCMethodDecl(PD->getSetterMethodDecl(), Setr); Setr += "{ "; // Synthesize an explicit cast to initialize the ivar. + // FIXME: deal with code generation implications for various property + // attributes (copy, retain, nonatomic). + // See objc-act.c:objc_synthesize_new_getter() for details. Setr += getIvarAccessString(ClassDecl, OID) + " = "; Setr += OID->getNameAsCString(); Setr += "; }"; -- 2.40.0