From 34de2c30c5499519eab42575b0ed489fb5865a99 Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Sun, 29 May 2011 10:23:06 +0000 Subject: [PATCH] Fixed bug #53848 (fgetcsv() ignores spaces at beginnings of fields). --- ext/standard/file.c | 28 ++++++++------------------- ext/standard/tests/file/bug53848.phpt | 25 ++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 20 deletions(-) create mode 100644 ext/standard/tests/file/bug53848.phpt diff --git a/ext/standard/file.c b/ext/standard/file.c index 527f12df61..868fbab4da 100644 --- a/ext/standard/file.c +++ b/ext/standard/file.c @@ -2098,29 +2098,17 @@ PHPAPI void php_fgetcsv(php_stream *stream, char delimiter, char enclosure, char tptr = temp; - /* 1. Strip any leading space */ - for (;;) { - inc_len = (bptr < limit ? (*bptr == '\0' ? 1: php_mblen(bptr, limit - bptr)): 0); - switch (inc_len) { - case -2: - case -1: - inc_len = 1; - php_ignore_value(php_mblen(NULL, 0)); - break; - case 0: - goto quit_loop_1; - case 1: - if (!isspace((int)*(unsigned char *)bptr) || *bptr == delimiter) { - goto quit_loop_1; - } - break; - default: - goto quit_loop_1; + inc_len = (bptr < limit ? (*bptr == '\0' ? 1: php_mblen(bptr, limit - bptr)): 0); + if (inc_len == 1) { + char *tmp = bptr; + while (isspace((int)*(unsigned char *)tmp)) { + tmp++; + } + if (*tmp == enclosure) { + bptr = tmp; } - bptr += inc_len; } - quit_loop_1: if (first_field && bptr == line_end) { add_next_index_null(return_value); break; diff --git a/ext/standard/tests/file/bug53848.phpt b/ext/standard/tests/file/bug53848.phpt new file mode 100644 index 0000000000..016d59d0ca --- /dev/null +++ b/ext/standard/tests/file/bug53848.phpt @@ -0,0 +1,25 @@ +--TEST-- +Bug #53848 (fgetcsv removes leading spaces from fields) +--FILE-- + +--EXPECT-- +array(2) { + [0]=> + string(1) "a" + [1]=> + string(1) "b" +} +array(2) { + [0]=> + string(3) " c" + [1]=> + string(3) " d" +} -- 2.40.0